Re: RFR: 8338428: Add logging if final VM flags while setting properties [v5]

2025-01-17 Thread Leonid Mesnik
On Fri, 17 Jan 2025 17:27:32 GMT, Roger Riggs wrote: > This seems like overkill for a weak use case. > > The resulting log file is in the scratch directory so it will not be retained > for long. In local builds, whoever is running the test could add the > arguments. Thanks for your feedback.

Re: RFR: 8338428: Add logging if final VM flags while setting properties [v5]

2025-01-17 Thread Roger Riggs
On Fri, 17 Jan 2025 15:59:50 GMT, Leonid Mesnik wrote: >> Some VM flags might depend on the environment and it makes sense to log >> final flags so it is possible to get their value when investigating failures. >> >> I added them to VMProps, so it is always dump final flags before running >> t

Re: RFR: 8338428: Add logging if final VM flags while setting properties [v5]

2025-01-17 Thread Roger Riggs
On Fri, 17 Jan 2025 15:59:50 GMT, Leonid Mesnik wrote: >> Some VM flags might depend on the environment and it makes sense to log >> final flags so it is possible to get their value when investigating failures. >> >> I added them to VMProps, so it is always dump final flags before running >> t

Re: RFR: 8338428: Add logging if final VM flags while setting properties [v5]

2025-01-17 Thread Leonid Mesnik
> Some VM flags might depend on the environment and it makes sense to log final > flags so it is possible to get their value when investigating failures. > > I added them to VMProps, so it is always dump final flags before running > tests using "-XX:+PrintFlagsFinal". > > Update: > There were i