Re: RFR: 8338409: Use record to simplify code

2024-08-15 Thread duke
On Fri, 2 Aug 2024 16:14:41 GMT, Shaojin Wen wrote: > j.u.Formatter$FixedString can be refactored to simplify the code using Record @wenshao Your change (at version c7ce3c724183ad3b4a09a9fac1d7411fdd8e) is now ready to be sponsored by a Committer. - PR Comment: https://git.op

Re: RFR: 8338409: Use record to simplify code

2024-08-14 Thread Chen Liang
On Fri, 2 Aug 2024 16:14:41 GMT, Shaojin Wen wrote: > j.u.Formatter$FixedString can be refactored to simplify the code using Record A simple cleanup. - Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20443#pullrequestreview-2239320206

Re: RFR: 8338409: Use record to simplify code

2024-08-14 Thread Claes Redestad
On Fri, 2 Aug 2024 16:14:41 GMT, Shaojin Wen wrote: > j.u.Formatter$FixedString can be refactored to simplify the code using Record Marked as reviewed by redestad (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20443#pullrequestreview-2239308638

Re: RFR: 8338409: Use record to simplify code

2024-08-14 Thread Chen Liang
On Fri, 2 Aug 2024 16:14:41 GMT, Shaojin Wen wrote: > j.u.Formatter$FixedString can be refactored to simplify the code using Record src/java.base/share/classes/java/util/Formatter.java line 3024: > 3022: } > 3023: > 3024: private static record FixedString(String s, int start, int end)