Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined [v2]

2024-12-03 Thread David M . Lloyd
On Thu, 28 Nov 2024 15:22:18 GMT, Jorn Vernee wrote: >> Allow `captureCallState` and `critical(true)` linker options to be combined. >> This allows passing a Java array to capture call state. >> >> One caveat is that the linker expects the memory to be aligned, which means >> that at least an

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined [v2]

2024-11-29 Thread Maurizio Cimadamore
On Thu, 28 Nov 2024 15:22:18 GMT, Jorn Vernee wrote: >> Allow `captureCallState` and `critical(true)` linker options to be combined. >> This allows passing a Java array to capture call state. >> >> One caveat is that the linker expects the memory to be aligned, which means >> that at least an

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined [v2]

2024-11-28 Thread Jorn Vernee
> Allow `captureCallState` and `critical(true)` linker options to be combined. > This allows passing a Java array to capture call state. > > One caveat is that the linker expects the memory to be aligned, which means > that at least an `int[]` has to be used (i.e. `byte[]` will no work). > > Th

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined

2024-11-28 Thread Jorn Vernee
On Thu, 28 Nov 2024 12:06:13 GMT, Maurizio Cimadamore wrote: >> Allow `captureCallState` and `critical(true)` linker options to be combined. >> This allows passing a Java array to capture call state. >> >> One caveat is that the linker expects the memory to be aligned, which means >> that at

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined

2024-11-28 Thread Jorn Vernee
On Wed, 27 Nov 2024 19:21:55 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/foreign/abi/NativeEntryPoint.java >> line 91: >> >>> 89: int checkIdx = 1; >>> 90: if ((needsReturnBuffer && methodType.parameterType(checkIdx++) >>> != long.class) >>> 91:

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined

2024-11-28 Thread Maurizio Cimadamore
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote: > Allow `captureCallState` and `critical(true)` linker options to be combined. > This allows passing a Java array to capture call state. > > One caveat is that the linker expects the memory to be aligned, which means > that at least an `int[

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined

2024-11-28 Thread Maurizio Cimadamore
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote: > Allow `captureCallState` and `critical(true)` linker options to be combined. > This allows passing a Java array to capture call state. > > One caveat is that the linker expects the memory to be aligned, which means > that at least an `int[

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined

2024-11-27 Thread Per Minborg
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote: > Allow `captureCallState` and `critical(true)` linker options to be combined. > This allows passing a Java array to capture call state. > > One caveat is that the linker expects the memory to be aligned, which means > that at least an `int[

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined

2024-11-27 Thread Maurizio Cimadamore
On Wed, 27 Nov 2024 19:21:30 GMT, Maurizio Cimadamore wrote: >> Allow `captureCallState` and `critical(true)` linker options to be combined. >> This allows passing a Java array to capture call state. >> >> One caveat is that the linker expects the memory to be aligned, which means >> that at

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined

2024-11-27 Thread Maurizio Cimadamore
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote: > Allow `captureCallState` and `critical(true)` linker options to be combined. > This allows passing a Java array to capture call state. > > One caveat is that the linker expects the memory to be aligned, which means > that at least an `int[

Re: RFR: 8336768: Allow captureCallState and critical linker options to be combined

2024-11-27 Thread Jorn Vernee
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote: > Allow `captureCallState` and `critical(true)` linker options to be combined. > This allows passing a Java array to capture call state. > > One caveat is that the linker expects the memory to be aligned, which means > that at least an `int[