Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-20 Thread Doug Lea
On Wed, 20 Nov 2024 10:36:13 GMT, Viktor Klang wrote: >> resetThreadLocals looks good although. A discussion point is whether reset >> should be done for all FJP instances, not just the common pool but not this >> PR. > > Thanks Alan. Yes, I think it should be considered to do it for all FJP >

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-20 Thread Viktor Klang
On Tue, 19 Nov 2024 19:12:29 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 4082: >> >>> 4080: AccessController.doPrivileged(new PrivilegedAction<>() { >>> 4081: public ForkJoinPool run() { >>> 4082:

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-20 Thread Viktor Klang
On Wed, 20 Nov 2024 08:11:34 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java >> line 247: >> >>> 245: = U.objectFieldOffset(Thread.class, "threadLocals"); >>> 246: private static final long INHERITABLETHREADLOCALS >>> 247:

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-20 Thread Alan Bateman
On Tue, 19 Nov 2024 16:57:05 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager > > src/java.base/share/classes/java/util/concu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Viktor Klang
On Sun, 17 Nov 2024 15:33:02 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Doug Lea
On Tue, 19 Nov 2024 16:54:04 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager > > src/java.base/share/classes/java/util/concu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Doug Lea
On Tue, 19 Nov 2024 16:52:44 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager > > src/java.base/share/classes/java/util/concu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Doug Lea
On Tue, 19 Nov 2024 16:10:19 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager > > src/java.base/share/classes/java/util/concu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Viktor Klang
On Sun, 17 Nov 2024 15:33:02 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-18 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same