On Wed, 30 Oct 2024 15:25:24 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Wed, 30 Oct 2024 13:22:21 GMT, Alan Bateman wrote:
>> I believe the check is already being done, right on the next line:
>> https://github.com/openjdk/jdk/blob/821c514a132e809a14648ddbb56f2ffee85fd35a/src/java.base/share/classes/jdk/internal/module/ModuleInfo.java#L192
>> which leads to:
>> ht
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to receive feedback.
>
> The main changes are:
> - `require
On Wed, 30 Oct 2024 12:49:16 GMT, Jan Lahoda wrote:
> Do I miss something?
Okay, so this must have been modified at some point to add/use
isSupportedModuleDescriptorVersion, in which case readModuleAttribute won't be
called. In that case, what you have is okay.
Minor nit, can you fix up the c
On Tue, 29 Oct 2024 17:25:37 GMT, Alan Bateman wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 18 commits:
>>
>> - Updating PreviewFeature metadata
>> - Cleanup.
>> - Merge branch 'master' into JDK-8335989
On Thu, 24 Oct 2024 06:40:42 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Thu, 24 Oct 2024 06:40:42 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to receive feedback.
>
> The main changes are:
> - `require
On Mon, 21 Oct 2024 11:03:44 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into JDK-8335989
>> - Reflecting review feedback.
>> - Cleanu
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Mon, 21 Oct 2024 11:07:29 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into JDK-8335989
>> - Reflecting review feedback.
>> - Cleanu
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Thu, 17 Oct 2024 11:39:51 GMT, Aggelos Biboudis
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into JDK-8335989
>> - Reflecting review feedback.
>> - Cleanup.
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Mon, 14 Oct 2024 14:23:22 GMT, Alan Bateman wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into JDK-8335989
>> - Reflecting review feedback.
>> - Cleanup.
>> -
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to receive feedback.
>
> The main changes are:
> - `require
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote:
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to rece
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to receive feedback.
>
> The main changes are:
> - `require
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote:
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to rece
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote:
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to rece
24 matches
Mail list logo
