Re: RFR: 8335252: ForceInline j.u.Formatter.Conversion#isValid [v2]

2024-06-28 Thread Shaojin Wen
On Fri, 28 Jun 2024 10:22:58 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert & use `@ForceInline` > > So the compound issue here is that there's a heuristic which prevents > inlining of l

Re: RFR: 8335252: ForceInline j.u.Formatter.Conversion#isValid [v2]

2024-06-28 Thread Claes Redestad
On Thu, 27 Jun 2024 14:12:36 GMT, Shaojin Wen wrote: >> Currently, the java.util.Formatter$Conversion::isValid method is implemented >> based on switch, which cannot be inlined because codeSize > 325. This >> problem can be avoided by implementing it with ImmutableBitSetPredicate. >> >> use `-

Re: RFR: 8335252: ForceInline j.u.Formatter.Conversion#isValid [v2]

2024-06-27 Thread Paul Sandoz
On Thu, 27 Jun 2024 14:12:36 GMT, Shaojin Wen wrote: >> Currently, the java.util.Formatter$Conversion::isValid method is implemented >> based on switch, which cannot be inlined because codeSize > 325. This >> problem can be avoided by implementing it with ImmutableBitSetPredicate. >> >> use `-