Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-13 Thread Jaikiran Pai
On Thu, 13 Jun 2024 08:05:15 GMT, Alan Bateman wrote: >> Looking briefly at this, I think we should be able to provide this as a >> feature of jtreg's support of `junit` test itself. I've created >> https://bugs.openjdk.org/browse/CODETOOLS-7903751 to investigate this >> support in jtreg. > >

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-13 Thread Alan Bateman
On Thu, 13 Jun 2024 06:59:39 GMT, Jaikiran Pai wrote: >> test/jdk/java/io/IO/IO.java line 192: >> >>> 190: // adapted from >>> https://junit.org/junit5/docs/current/user-guide/#extensions-lifecycle-callbacks-timing-extension >>> 191: >>> 192: public static class TimingExtension impleme

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-13 Thread Jaikiran Pai
On Thu, 13 Jun 2024 06:29:36 GMT, Alan Bateman wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Disable timeout in expect scripts > > test/jdk/java/io/IO/IO.java line 192: > >> 190: // adapted from >> https://j

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-12 Thread Alan Bateman
On Wed, 12 Jun 2024 19:06:23 GMT, Pavel Rappo wrote: >> Please review this fix for an intermittent test failure. >> >> On some configurations, the default `expect` timeout of 10 seconds is >> insufficient. It is increased to 20; it's hard to imagine a configuration >> for which that new value

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-12 Thread Pavel Rappo
> Please review this fix for an intermittent test failure. > > On some configurations, the default `expect` timeout of 10 seconds is > insufficient. It is increased to 20; it's hard to imagine a configuration for > which that new value would still be insufficient, but we'll see. > > Aside from