Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v10]

2024-04-29 Thread Tim Prinzing
On Mon, 29 Apr 2024 20:01:38 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.Fil

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v10]

2024-04-29 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v9]

2024-04-29 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v8]

2024-04-18 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v7]

2024-04-18 Thread Erik Gahlin
On Thu, 18 Apr 2024 18:59:20 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.Fil

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v7]

2024-04-18 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v6]

2024-04-18 Thread Tim Prinzing
On Thu, 18 Apr 2024 18:46:36 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.Fil

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v6]

2024-04-18 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

2024-04-18 Thread Erik Gahlin
On Thu, 18 Apr 2024 15:14:10 GMT, Tim Prinzing wrote: >> I think it might be the cause for >> https://bugs.openjdk.org/browse/JDK-8329330 I have sent out a PR to remove >> those separately so the fix can be backported. >> https://github.com/openjdk/jdk/pull/18843 > > That's correct, it is an u

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

2024-04-18 Thread Tim Prinzing
On Thu, 18 Apr 2024 14:32:28 GMT, Erik Gahlin wrote: >> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 66: >> >>> 64: FileWriteEvent.class, >>> 65: SocketReadEvent.class, >>> 66: SocketWriteEvent.class, >> >> I'm guessing that this change which

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

2024-04-18 Thread Erik Gahlin
On Wed, 17 Apr 2024 14:05:28 GMT, Daniel Fuchs wrote: >> Tim Prinzing has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test file local to test > > src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 66: > >> 64:

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

2024-04-18 Thread Daniel Fuchs
On Wed, 17 Apr 2024 01:34:07 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.Fil

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

2024-04-18 Thread Alan Bateman
On Wed, 17 Apr 2024 01:34:07 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.Fil

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-16 Thread Tim Prinzing
On Tue, 16 Apr 2024 15:49:08 GMT, Daniel Fuchs wrote: >> I'm not sure what you mean about the recording. The file is the >> AsynchronousFileChannel under test and does not contain the event recording. > > It's anyway better to create temporary files in the test scratch directory > rather than

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

2024-04-16 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-16 Thread Daniel Fuchs
On Mon, 15 Apr 2024 20:41:10 GMT, Tim Prinzing wrote: >> test/jdk/jdk/jfr/event/io/TestAsynchronousFileChannelEvents.java line 50: >> >>> 48: >>> 49: public static void main(String[] args) throws Throwable { >>> 50: File blah = File.createTempFile("blah", null); >> >> Can you chang

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-15 Thread Alan Bateman
On Mon, 15 Apr 2024 20:39:26 GMT, Tim Prinzing wrote: >> test/jdk/jdk/jfr/event/io/TestAsynchronousFileChannelEvents.java line 64: >> >>> 62: >>> 63: data.flip(); >>> 64: ch.write(data, 0); >> >> This just initiates the write operation, it doesn't wait until it complete

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v4]

2024-04-15 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-15 Thread Tim Prinzing
On Tue, 2 Apr 2024 04:48:37 GMT, Alan Bateman wrote: >> Tim Prinzing has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add support for AsynchronousFileChannel.force(). > > src/java.base/share/classes/jdk/internal/event/FileForceEvent.java

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v3]

2024-04-15 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-01 Thread Alan Bateman
On Mon, 1 Apr 2024 23:37:21 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.File

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-01 Thread Alan Bateman
On Mon, 1 Apr 2024 23:37:21 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.File

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-01 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event

2024-03-30 Thread Alan Bateman
On Fri, 29 Mar 2024 00:52:46 GMT, Tim Prinzing wrote: > Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForc

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event

2024-03-29 Thread Tim Prinzing
On Fri, 29 Mar 2024 00:52:46 GMT, Tim Prinzing wrote: > Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForc

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event

2024-03-28 Thread Alan Bateman
On Fri, 29 Mar 2024 00:52:46 GMT, Tim Prinzing wrote: > Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForc