Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v2]

2025-02-21 Thread Alexey Semenyuk
On Sat, 22 Feb 2025 04:10:17 GMT, Alexander Matveev wrote: > maybe bug in our embed code The code has been the same since the first release of jpackage. > do we know when it was introduced and figure out root cause Quote from the bug description: > JDK 21.0.2 (Temurin) > > A DESCRIPTION OF T

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v2]

2025-02-21 Thread Alexander Matveev
On Sat, 22 Feb 2025 02:32:29 GMT, Alexey Semenyuk wrote: > Do you have a better idea? Can we sign `msiwrapper.exe` which does not have any embedded msi? `jmod.exe` can be used to extract it from `resources`. If it works maybe bug in our embed code. If it does not work do we know when it was in

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v2]

2025-02-21 Thread Alexey Semenyuk
On Sat, 22 Feb 2025 02:21:14 GMT, Alexander Matveev wrote: > Can we add test which will use SignTool to sign produced .exe installer? What would be the action if the test fails? - PR Comment: https://git.openjdk.org/jdk/pull/23732#issuecomment-2675957416

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v2]

2025-02-21 Thread Alexey Semenyuk
On Sat, 22 Feb 2025 02:17:32 GMT, Alexander Matveev wrote: > Should user just take it from another JDK which works? Yes > It does not look like a solution to this issue. Do you have a better idea? - PR Comment: https://git.openjdk.org/jdk/pull/23732#issuecomment-2675954065

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v2]

2025-02-21 Thread Alexander Matveev
On Sat, 22 Feb 2025 01:05:45 GMT, Alexey Semenyuk wrote: >> Support the use of a custom msi wrapper executable when building an exe >> installer. >> >> Put `installer.exe` file in the resource directory and jpackage will use it >> instead of the default `msiwrapper.exe` resource for exe instal

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v2]

2025-02-21 Thread Alexander Matveev
On Sat, 22 Feb 2025 01:05:45 GMT, Alexey Semenyuk wrote: >> Support the use of a custom msi wrapper executable when building an exe >> installer. >> >> Put `installer.exe` file in the resource directory and jpackage will use it >> instead of the default `msiwrapper.exe` resource for exe instal

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v2]

2025-02-21 Thread Alexey Semenyuk
On Sat, 22 Feb 2025 01:05:45 GMT, Alexey Semenyuk wrote: >> Support the use of a custom msi wrapper executable when building an exe >> installer. >> >> Put `installer.exe` file in the resource directory and jpackage will use it >> instead of the default `msiwrapper.exe` resource for exe instal

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v2]

2025-02-21 Thread Alexey Semenyuk
> Support the use of a custom msi wrapper executable when building an exe > installer. > > Put `installer.exe` file in the resource directory and jpackage will use it > instead of the default `msiwrapper.exe` resource for exe installer. > > To test this feature created a test that builds exe in