On Tue, 7 May 2024 13:44:06 GMT, Emanuel Peter wrote:
> Thanks for the extra tests!
>
Thanks for reviewing.
> Can you measure how much time each test now takes on your machine?
>
Only TestRoundVectorFloatAll.java took longer, but still in one minute, others
run rather quicker than it.
> I
On Tue, 7 May 2024 13:30:12 GMT, Emanuel Peter wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix issues; modify vm options to make sure test the expected behaviors.
>
> test/hotspot/jtreg/compiler/floatingpoint/Test
On Tue, 7 May 2024 13:36:55 GMT, Emanuel Peter wrote:
>> test/hotspot/jtreg/compiler/floatingpoint/TestRoundFloatAll.java line 31:
>>
>>> 29: * @library /test/lib /
>>> 30: * @modules java.base/jdk.internal.math
>>> 31: * @run main/othervm -XX:-TieredCompilation
>>> -XX:CompileThresholdScali
On Tue, 7 May 2024 13:23:48 GMT, Emanuel Peter wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix issues; modify vm options to make sure test the expected behaviors.
>
> test/hotspot/jtreg/compiler/floatingpoint/Test
On Mon, 29 Apr 2024 11:38:27 GMT, Hamlin Li wrote:
>> HI,
>> Can you have a look at this patch adding some tests for Math.round
>> instrinsics?
>> Thanks!
>>
>> ### FYI:
>> During the development of RoundVF/RoundF, we faced the issues which were
>> only spotted by running test exhaustively aga
> HI,
> Can you have a look at this patch adding some tests for Math.round
> instrinsics?
> Thanks!
>
> ### FYI:
> During the development of RoundVF/RoundF, we faced the issues which were only
> spotted by running test exhaustively against 32/64 bits range of int/long.
> It's helpful to add thes
