Re: RFR: 8323621: JDK build should exclude snippet class in java.lang.foreign [v2]

2024-01-29 Thread Maurizio Cimadamore
On Mon, 29 Jan 2024 14:03:42 GMT, Per Minborg wrote: >> This PR proposes to remove the snippet files in >> `java/lang/foreign/snippet-files` from the build. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Correct path to ex

Re: RFR: 8323621: JDK build should exclude snippet class in java.lang.foreign [v2]

2024-01-29 Thread Per Minborg
> This PR proposes to remove the snippet files in > `java/lang/foreign/snippet-files` from the build. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Correct path to excluded directory - Changes: - all: https://git.ope

Re: RFR: 8323621: JDK build should exclude snippet class in java.lang.foreign [v2]

2024-01-29 Thread Per Minborg
On Mon, 15 Jan 2024 13:27:25 GMT, Magnus Ihse Bursie wrote: >> If possible, we should simply exclude all files in directories that have `-` >> (minus sign) in their name; this is the intentional design to prevent javac >> from compiling those classes as package names cannot include `-`. > > I a

Re: RFR: 8323621: JDK build should exclude snippet class in java.lang.foreign

2024-01-15 Thread Magnus Ihse Bursie
On Sun, 14 Jan 2024 04:07:29 GMT, Chen Liang wrote: >> make/modules/java.base/Java.gmk line 41: >> >>> 39: java/lang/classfile/snippet-files \ >>> 40: java/lang/classfile/components/snippet-files \ >>> 41: jdk/lang/foreign/snippet-files >> >> I can't find this directory in the sourc

Re: RFR: 8323621: JDK build should exclude snippet class in java.lang.foreign

2024-01-13 Thread Chen Liang
On Fri, 12 Jan 2024 17:31:55 GMT, Erik Joelsson wrote: >> This PR proposes to remove the snippet files in >> `java/lang/foreign/snippet-files` from the build. > > make/modules/java.base/Java.gmk line 41: > >> 39: java/lang/classfile/snippet-files \ >> 40: java/lang/classfile/components/

Re: RFR: 8323621: JDK build should exclude snippet class in java.lang.foreign

2024-01-12 Thread Erik Joelsson
On Fri, 12 Jan 2024 15:17:42 GMT, Per Minborg wrote: > This PR proposes to remove the snippet files in > `java/lang/foreign/snippet-files` from the build. make/modules/java.base/Java.gmk line 41: > 39: java/lang/classfile/snippet-files \ > 40: java/lang/classfile/components/snippet-fil