Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v5]

2024-01-29 Thread Per Minborg
On Sun, 28 Jan 2024 00:57:24 GMT, ExE Boss wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright year >> - Add test for zero-out > > test/jdk/java/foreign/TestScope.java line 150: > >> 148: } >> 1

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v5]

2024-01-27 Thread ExE Boss
On Fri, 12 Jan 2024 14:35:01 GMT, Per Minborg wrote: >> This PR proposes to add a clarification that an `Arena` always returns >> zeroed-out segments for `Arena::allocate` methods. >> >> Note that other overloaded methods refer to the abstract `Arena::allocate` >> method via implementation not

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v5]

2024-01-12 Thread Per Minborg
> This PR proposes to add a clarification that an `Arena` always returns > zeroed-out segments for `Arena::allocate` methods. > > Note that other overloaded methods refer to the abstract `Arena::allocate` > method via implementation notes. Per Minborg has updated the pull request incrementally

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v4]

2024-01-12 Thread Per Minborg
> This PR proposes to add a clarification that an `Arena` always returns > zeroed-out segments for `Arena::allocate` methods. > > Note that other overloaded methods refer to the abstract `Arena::allocate` > method via implementation notes. Per Minborg has updated the pull request incrementally

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v3]

2024-01-12 Thread Jorn Vernee
On Fri, 12 Jan 2024 13:06:39 GMT, Per Minborg wrote: >> This PR proposes to add a clarification that an `Arena` always returns >> zeroed-out segments for `Arena::allocate` methods. >> >> Note that other overloaded methods refer to the abstract `Arena::allocate` >> method via implementation not

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v3]

2024-01-12 Thread Maurizio Cimadamore
On Fri, 12 Jan 2024 13:06:39 GMT, Per Minborg wrote: >> This PR proposes to add a clarification that an `Arena` always returns >> zeroed-out segments for `Arena::allocate` methods. >> >> Note that other overloaded methods refer to the abstract `Arena::allocate` >> method via implementation not

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v3]

2024-01-12 Thread Per Minborg
> This PR proposes to add a clarification that an `Arena` always returns > zeroed-out segments for `Arena::allocate` methods. > > Note that other overloaded methods refer to the abstract `Arena::allocate` > method via implementation notes. Per Minborg has updated the pull request incrementally

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v2]

2024-01-12 Thread Jorn Vernee
On Thu, 11 Jan 2024 07:59:37 GMT, Per Minborg wrote: >> This PR proposes to add a clarification that an `Arena` always returns >> zeroed-out segments for `Arena::allocate` methods. >> >> Note that other overloaded methods refer to the abstract `Arena::allocate` >> method via implementation not

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v2]

2024-01-11 Thread Per Minborg
> This PR proposes to add a clarification that an `Arena` always returns > zeroed-out segments for `Arena::allocate` methods. > > Note that other overloaded methods refer to the abstract `Arena::allocate` > method via implementation notes. Per Minborg has updated the pull request incrementally

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate

2024-01-10 Thread Maurizio Cimadamore
On Wed, 10 Jan 2024 14:29:37 GMT, Jorn Vernee wrote: >> The choice here is: if we allow non-zeroing implementation, implementors of >> Arena have more flexibility, but clients have less guarantees (how does a >> client know if what they get back is zeroed?) > >> (how does a client know if what

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate

2024-01-10 Thread Jorn Vernee
On Wed, 10 Jan 2024 14:21:15 GMT, Maurizio Cimadamore wrote: > (how does a client know if what they get back is zeroed?) It seems similar to e.g. a HashMap vs. LinkedHashMap with regards to ordering. The creator of the Arena would decide the zeroing strategy. - PR Review Comment:

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate

2024-01-10 Thread Maurizio Cimadamore
On Wed, 10 Jan 2024 14:12:02 GMT, Jorn Vernee wrote: >> This PR proposes to add a clarification that an `Arena` always returns >> zeroed-out segments for `Arena::allocate` methods. >> >> Note that other overloaded methods refer to the abstract `Arena::allocate` >> method via implementation not

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate

2024-01-10 Thread Maurizio Cimadamore
On Wed, 10 Jan 2024 14:19:29 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/foreign/Arena.java line 269: >> >>> 267: * @implSpec >>> 268: * Implementations of this method must return a native, >>> zero-initialized segment >>> 269: * featuring the reques

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate

2024-01-10 Thread Jorn Vernee
On Mon, 8 Jan 2024 16:16:50 GMT, Per Minborg wrote: > This PR proposes to add a clarification that an `Arena` always returns > zeroed-out segments for `Arena::allocate` methods. > > Note that other overloaded methods refer to the abstract `Arena::allocate` > method via implementation notes. s

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate

2024-01-08 Thread Maurizio Cimadamore
On Mon, 8 Jan 2024 16:16:50 GMT, Per Minborg wrote: > This PR proposes to add a clarification that an `Arena` always returns > zeroed-out segments for `Arena::allocate` methods. > > Note that other overloaded methods refer to the abstract `Arena::allocate` > method via implementation notes. M