On Thu, 14 Dec 2023 14:55:08 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
>> `ZipFile/input.jar`.
>>
>> Binary test vectors are harder to analyze, and sharing test vectors across
>> unrelated tests increases maintenance burden. It wo
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
On Thu, 14 Dec 2023 11:39:22 GMT, Lance Andersen wrote:
> (though CopyZipFile could use a junit conversion ;-)
Agreed, I have included that conversion in this PR :-) This test can make good
use of `assertThrows` and splitting different concerns into separate test
methods.
-
PR Co
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
On Thu, 14 Dec 2023 11:39:22 GMT, Lance Andersen wrote:
>> The scope of this PR has now expanded to removing uses of the `input.zip`
>> and `input.jar` files, updating any test using them to produce their own
>> test vectors, and convert affected tests to JUnit.
>>
>> I'm marking the PR ready
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
On Thu, 14 Dec 2023 10:13:31 GMT, Eirik Bjorsnos wrote:
> The scope of this PR has now expanded to removing uses of the `input.zip` and
> `input.jar` files, updating any test using them to produce their own test
> vectors, and convert affected tests to JUnit.
>
> I'm marking the PR ready for r
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
On Fri, 8 Dec 2023 20:28:20 GMT, Eirik Bjorsnos wrote:
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be
11 matches
Mail list logo
