Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v3]

2023-10-18 Thread Markus Grönlund
On Mon, 16 Oct 2023 11:28:36 GMT, Erik Gahlin wrote: >> Hi, >> >> Could I have a review of an enhancement that replaces the use of ASM with >> the new Class-File API. This change only deals with bytecode that writes >> event data into buffers. Bytecode transformations carried out by classes in

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v3]

2023-10-16 Thread Erik Gahlin
On Sun, 15 Oct 2023 23:46:45 GMT, Chen Liang wrote: >> Erik Gahlin has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Blessed order > > src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 227: > >> 225: for (M

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v3]

2023-10-16 Thread Erik Gahlin
> Hi, > > Could I have a review of an enhancement that replaces the use of ASM with the > new Class-File API. This change only deals with bytecode that writes event > data into buffers. Bytecode transformations carried out by classes in > jdk.jfr.internal.intrument package are kept as is. Plan