On Mon, 16 Oct 2023 19:24:51 GMT, Jorn Vernee wrote:
> Ok. I'm assuming there are currently some failing tests due to the mismatch
> in ABI? (assuming the test libraries are compiled for the packed ABI)
We should be careful with the names:
- "#pragma align (power)" is the default which is curr
On Mon, 16 Oct 2023 15:54:12 GMT, Martin Doerr wrote:
> I have filed a subtask to handle the tests:
> https://bugs.openjdk.org/browse/JDK-8318175 This PR is now compatible with
> "#pragma align (natural)", but permits layouts according to the default
> setting. This allows writing Java code wh
On Mon, 16 Oct 2023 14:06:09 GMT, Martin Doerr wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
>> double values have only 4 Byte alignment within structures. This PR is based
>> on JDK22 version of the FFI.
>
> Martin Doerr has updated the pull request inc
On Mon, 16 Oct 2023 13:57:11 GMT, Martin Doerr wrote:
>> Err, actually using `member.equals(C_DOUBLE)` in the above doesn't work
>> since it still checks alignment. What you have with checking for
>> `ValueLayout` and `carrier() == double.class` is better, but the byte order
>> should also be
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment within structures. This PR is based
> on JDK22 version of the FFI.
Martin Doerr has updated the pull request incrementally with one additional
commit since the last revision
On Sat, 14 Oct 2023 18:01:00 GMT, Jorn Vernee wrote:
>> I was thinking something like this:
>>
>>
>> diff --git
>> a/src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java
>> b/src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java
>> index dbd9a3f67a4..10b
