Re: RFR: 8316426: Optimization for HexFormat.formatHex [v8]

2023-10-06 Thread 温绍锦
On Wed, 27 Sep 2023 13:35:55 GMT, Roger Riggs wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> reduce the size of HexFormat##DIGITS, from 256 to 128 > > It is conventional to get re-reviews of any change and give the reviewe

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v8]

2023-09-27 Thread Roger Riggs
On Wed, 27 Sep 2023 09:07:44 GMT, 温绍锦 wrote: >> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table >> were discussed. >> >> But if the input is byte[], using lookup table can improve performance. >> >> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v8]

2023-09-27 Thread 温绍锦
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table > were discussed. > > But if the input is byte[], using lookup table can improve performance. > > For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]), > If the length of byte[] is larger, the pe