Re: RFR: 8312414: Make java.util.ServiceLoader.LANG_ACCESS final

2023-07-20 Thread Jaikiran Pai
On Tue, 18 Jul 2023 20:06:56 GMT, Andrey Turbanov wrote: > Found opportunity to make static `ServiceLoader.LANG_ACCESS` field `final`. Marked as reviewed by jpai (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14926#pullrequestreview-1538660335

Re: RFR: 8312414: Make java.util.ServiceLoader.LANG_ACCESS final

2023-07-19 Thread Alan Bateman
On Tue, 18 Jul 2023 20:06:56 GMT, Andrey Turbanov wrote: > Found opportunity to make static `ServiceLoader.LANG_ACCESS` field `final`. Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14926#pullrequestreview-1538485598

Re: RFR: 8312414: Make java.util.ServiceLoader.LANG_ACCESS final

2023-07-19 Thread Alan Bateman
On Tue, 18 Jul 2023 20:06:56 GMT, Andrey Turbanov wrote: > Found opportunity to make static `ServiceLoader.LANG_ACCESS` field `final`. src/java.base/share/classes/java/util/ServiceLoader.java line 426: > 424: > 425: private static final JavaLangAccess LANG_ACCESS = > 426: Share