Re: RFR: 8311663: Additional refactoring of Locale tests to JUnit [v2]

2023-07-17 Thread Naoto Sato
On Mon, 17 Jul 2023 21:31:33 GMT, Justin Lu wrote: >> Please review this PR which refactors more java.util.Locale tests to JUnit >> with some minor cleanup as well. >> >> Although some of the files could benefit from being renamed bugNNN to >> something more descriptive, this makes reviewi

Re: RFR: 8311663: Additional refactoring of Locale tests to JUnit [v2]

2023-07-17 Thread Justin Lu
On Mon, 17 Jul 2023 10:58:12 GMT, Andrey Turbanov wrote: >> Justin Lu has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Review: Explicitly run via othervm and pass locale args in cmdline >> - Review: ws removal in Bug8179071.java >> -

Re: RFR: 8311663: Additional refactoring of Locale tests to JUnit [v2]

2023-07-17 Thread Justin Lu
On Fri, 14 Jul 2023 21:59:40 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Review: Explicitly run via othervm and pass locale args in cmdline >> - Review: ws removal in Bug8179071.java >> - Revie

Re: RFR: 8311663: Additional refactoring of Locale tests to JUnit [v2]

2023-07-17 Thread Justin Lu
> Please review this PR which refactors more java.util.Locale tests to JUnit > with some minor cleanup as well. > > Although some of the files could benefit from being renamed bugNNN to > something more descriptive, this makes reviewing harder, and will be handled > separately. Justin Lu h

Re: RFR: 8311663: Additional refactoring of Locale tests to JUnit

2023-07-17 Thread Andrey Turbanov
On Thu, 13 Jul 2023 23:23:42 GMT, Justin Lu wrote: > Please review this PR which refactors more java.util.Locale tests to JUnit > with some minor cleanup as well. > > Although some of the files could benefit from being renamed bugNNN to > something more descriptive, this makes reviewing ha

Re: RFR: 8311663: Additional refactoring of Locale tests to JUnit

2023-07-14 Thread Naoto Sato
On Thu, 13 Jul 2023 23:23:42 GMT, Justin Lu wrote: > Please review this PR which refactors more java.util.Locale tests to JUnit > with some minor cleanup as well. > > Although some of the files could benefit from being renamed bugNNN to > something more descriptive, this makes reviewing ha