Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v2]

2023-07-05 Thread Pavel Rappo
On Wed, 5 Jul 2023 15:46:56 GMT, Roger Riggs wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adhere to surrounding code style > > src/java.base/share/classes/java/text/CompactNumberFormat.java line 2364: > >> 2362:

Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v2]

2023-07-05 Thread Pavel Rappo
On Wed, 5 Jul 2023 15:47:56 GMT, Roger Riggs wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adhere to surrounding code style > > src/java.base/share/classes/java/text/DecimalFormat.java line 2926: > >> 2924:

Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v2]

2023-07-05 Thread Pavel Rappo
> Please review this PR to use modern APIs and language features to simplify > `equals` and `hashCode` in the java.text area. > > * Some changes to `equals` and `hashCode` are refactoring rather than > modernization. Such changes can be as trivial as rearranging, adding, or > commenting checks.