Re: RFR: 8309838: Classfile API Util.toBinaryName and other cleanup

2023-06-13 Thread Adam Sotona
On Mon, 12 Jun 2023 09:45:18 GMT, Chen Liang wrote: > Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the > typos you pointed out and removed other redundancies in classfile Util as > well. It looks good 👍 - Marked as reviewed by asotona (Reviewer). PR Re

Re: RFR: 8309838: Classfile API Util.toBinaryName and other cleanup

2023-06-12 Thread Chen Liang
On Mon, 12 Jun 2023 09:45:18 GMT, Chen Liang wrote: > Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the > typos you pointed out and removed other redundancies in classfile Util as > well. @asotona Can you please review this when you are free? - PR Commen

Re: RFR: 8309838: Classfile API Util.toBinaryName and other cleanup

2023-06-12 Thread Chen Liang
On Mon, 12 Jun 2023 10:45:03 GMT, ExE Boss wrote: >> Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the >> typos you pointed out and removed other redundancies in classfile Util as >> well. > > src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 90: >

Re: RFR: 8309838: Classfile API Util.toBinaryName and other cleanup

2023-06-12 Thread ExE Boss
On Mon, 12 Jun 2023 09:45:18 GMT, Chen Liang wrote: > Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the > typos you pointed out and removed other redundancies in classfile Util as > well. src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 90: > 88