On Wed, 31 May 2023 14:53:09 GMT, Aleksey Shipilev wrote:
>> UUID is very important class that is used to track identities of objects in
>> large scale systems. Yet, the coverage in JDK test is disappointing: it
>> tests only 100 of UUID instances per test, which is way too small to detect
>>
On Wed, 31 May 2023 14:46:59 GMT, Aleksey Shipilev wrote:
>> Two thoughts here.
>> The random number source (SecureRandom) should have its own tests, UUID has
>> a simple dependency on a generator.
>> The test for UUID is that it composes the bits into the UUID correctly. The
>> randomness
On Wed, 31 May 2023 14:53:09 GMT, Aleksey Shipilev wrote:
>> UUID is very important class that is used to track identities of objects in
>> large scale systems. Yet, the coverage in JDK test is disappointing: it
>> tests only 100 of UUID instances per test, which is way too small to detect
>>
> UUID is very important class that is used to track identities of objects in
> large scale systems. Yet, the coverage in JDK test is disappointing: it tests
> only 100 of UUID instances per test, which is way too small to detect
> collisions due to the bad randomness for example.
>
> I have so
On Wed, 31 May 2023 14:17:40 GMT, Roger Riggs wrote:
> Two thoughts here. The random number source (SecureRandom) should have its
> own tests, UUID has a simple dependency on a generator. The test for UUID is
> that it composes the bits into the UUID correctly. The randomness of the
> generato
On Wed, 31 May 2023 14:05:20 GMT, Aleksey Shipilev wrote:
>> My point was that its probably not practical to test (more than once).
>> If it fails, it will be considered just as you propose and disregarded and
>> in the meantime consumes test cycles in each of the test contexts. Either
>> pro
On Wed, 31 May 2023 13:11:08 GMT, Roger Riggs wrote:
>> This is a non-practical concern, IMO. By spec, `UUID.randomUUID` is
>> generated from the cryptographically secure random, with >120 bits of
>> randomness, so the collision is extremely unlikely. Collision math involves
>> birthday parado
On Wed, 31 May 2023 07:38:39 GMT, Aleksey Shipilev wrote:
>> test/jdk/java/util/UUID/UUIDTest.java line 79:
>>
>>> 77: }
>>> 78: if (!set.add(u)) {
>>> 79: throw new Exception("UUID collision: " + u);
>>
>> I would be concerned that if this failure was re
On Tue, 30 May 2023 20:55:39 GMT, Roger Riggs wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/util/UUID/UUIDTest.java line 79:
>
>> 77: }
>> 78: if (!s
On Tue, 30 May 2023 09:15:13 GMT, Aleksey Shipilev wrote:
>> UUID is very important class that is used to track identities of objects in
>> large scale systems. Yet, the coverage in JDK test is disappointing: it
>> tests only 100 of UUID instances per test, which is way too small to detect
>>
On Tue, 30 May 2023 09:15:13 GMT, Aleksey Shipilev wrote:
>> UUID is very important class that is used to track identities of objects in
>> large scale systems. Yet, the coverage in JDK test is disappointing: it
>> tests only 100 of UUID instances per test, which is way too small to detect
>>
On Tue, 30 May 2023 09:15:13 GMT, Aleksey Shipilev wrote:
>> UUID is very important class that is used to track identities of objects in
>> large scale systems. Yet, the coverage in JDK test is disappointing: it
>> tests only 100 of UUID instances per test, which is way too small to detect
>>
On Mon, 29 May 2023 06:53:35 GMT, Jaikiran Pai wrote:
> Overall, this test-only change look OK to me.
Thanks for looking at it! I believe I addressed the comments in the revision.
-
PR Comment: https://git.openjdk.org/jdk/pull/14134#issuecomment-1568078384
> UUID is very important class that is used to track identities of objects in
> large scale systems. Yet, the coverage in JDK test is disappointing: it tests
> only 100 of UUID instances per test, which is way too small to detect
> collisions due to the bad randomness for example.
>
> I have so
On Mon, 29 May 2023 06:48:10 GMT, Jaikiran Pai wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/util/UUID/UUIDTest.java line 40:
>
>> 38: private static final int COUNT = 1
On Wed, 24 May 2023 19:18:33 GMT, Aleksey Shipilev wrote:
> UUID is very important class that is used to track identities of objects in
> large scale systems. Yet, the coverage in JDK test is disappointing: it tests
> only 100 of UUID instances per test, which is way too small to detect
> coll
On Wed, 24 May 2023 19:18:33 GMT, Aleksey Shipilev wrote:
> UUID is very important class that is used to track identities of objects in
> large scale systems. Yet, the coverage in JDK test is disappointing: it tests
> only 100 of UUID instances per test, which is way too small to detect
> coll
17 matches
Mail list logo
