On Mon, 22 May 2023 19:28:26 GMT, Roger Riggs wrote:
> Thanks for the updates.
Thanks for all the comments (and the approval).
-
PR Comment: https://git.openjdk.org/jdk/pull/13957#issuecomment-1557863535
On Thu, 18 May 2023 19:14:02 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8308016: Address reviewer c
On Thu, 18 May 2023 18:23:53 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> com
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Address reviewer comments since previous commit
-
Changes:
- all: https:/
On Wed, 17 May 2023 20:51:29 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated cha
On Wed, 17 May 2023 15:50:13 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/io/RandomAccessFile.java line 904:
>>
>>> 902: * {@code b7}, and {@code b8,} where:
>>> 903: * {@snippet lang=java :
>>> 904: * 0 <= b1, b2, b3, b4, b5, b6, b7, b8 <= 255,
>>
>> Same:
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains sev
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Reinstate @snippet for RandomAccessFile::readLong
-
Changes:
- all: https
On Sun, 14 May 2023 05:50:20 GMT, Tagir F. Valeev wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8308016: Remove ellipses ("...") from snippets
>
> src/java.base/share/classes/java/io/RandomAccessFile.java lin
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Reduce linking in File::toPath snippet
-
Changes:
- all: https://git.open
On Mon, 15 May 2023 20:48:47 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8308016: Fix link in snippe
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Fix link in snippet of File::toPath
-
Changes:
- all: https://git.openjdk
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Address reviewer comments since previous commit
-
Changes:
- all: https:/
On Sun, 14 May 2023 05:47:50 GMT, Tagir F. Valeev wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8308016: Remove ellipses ("...") from snippets
>
> src/java.base/share/classes/java/io/FilePermission.java line
On Fri, 12 May 2023 19:02:46 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8308016: Remove ellipses ("
On Fri, 12 May 2023 17:59:32 GMT, Lance Andersen wrote:
>> I have been just trying to keep it as similar visually as possible but what
>> you say is reasonable.
>
> Agree, that I would make the code valid when using a snippet
There's a replacement tag for this. Some people use label, e.g.
code
On Fri, 12 May 2023 19:02:46 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8308016: Remove ellipses ("
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Remove ellipses ("...") from snippets
-
Changes:
- all: https://git.openj
On Fri, 12 May 2023 17:52:29 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Console.java line 124:
>>
>>> 122: * if (con != null) {
>>> 123: * Scanner sc = new Scanner(con.reader());
>>> 124: * ...
>>
>> I'm not sure how you fe
On Fri, 12 May 2023 17:31:32 GMT, Justin Lu wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> src/java.base/share/classes/java/io/Console.java line 124:
>
>> 122: * if (con != null) {
>> 123: * Scanner sc = new Scanner(
On Fri, 12 May 2023 16:17:38 GMT, Brian Burkhalter wrote:
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
src/java.base/share/classes/java/io/Console.java line 124:
> 122: * if (con != null) {
> 123: * Scanner sc = new Scanner(co
21 matches
Mail list logo
