Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE

2023-06-13 Thread Mandy Chung
On Tue, 13 Jun 2023 23:14:29 GMT, Chen Liang wrote: > Hello, > > This pull request contains a git cherry-pick of commit > openjdk/jdk@75dcc4ef94d90e4aa7f8ca5eccc97c91492d6eed, which fixed an NPE in > IndirectVarHandle.isAccessModeSupported, reproducible via the return value of > MethodHandles

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v3]

2023-06-12 Thread Mandy Chung
On Mon, 12 Jun 2023 23:17:03 GMT, Chen Liang wrote: >> test/jdk/java/lang/invoke/VarHandles/IndirectVarHandleTest.java line 44: >> >>> 42: var lookup = MethodHandles.lookup(); >>> 43: var intArrayVh = >>> MethodHandles.arrayElementVarHandle(int[].class); >>> 44: var addO

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v3]

2023-06-12 Thread Chen Liang
On Mon, 12 Jun 2023 22:54:08 GMT, Mandy Chung wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Wrap lines that are too long > > test/jdk/java/lang/invoke/VarHandles/IndirectVarHandleTest.java line 44: > >> 42:

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v3]

2023-06-12 Thread Chen Liang
> Fixes the NPE in IndirectVarHandle.isAccessModeSupported by delegating to the > target var handle. In addition, simplified the MH caching in Indirect VH and > removed redundant overrides (already available via var form). This was split > from #13821 as suggested by Mandy Chung, which allows ea

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v2]

2023-06-12 Thread Chen Liang
> Fixes the NPE in IndirectVarHandle.isAccessModeSupported by delegating to the > target var handle. In addition, simplified the MH caching in Indirect VH and > removed redundant overrides (already available via var form). This was split > from #13821 as suggested by Mandy Chung, which allows ea

Re: RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE

2023-06-12 Thread Mandy Chung
On Mon, 12 Jun 2023 05:27:35 GMT, Chen Liang wrote: > Fixes the NPE in IndirectVarHandle.isAccessModeSupported by delegating to the > target var handle. In addition, simplified the MH caching in Indirect VH and > removed redundant overrides (already available via var form). This was split > fr