Re: RFR: 8305846: Support compilation in Proc test utility

2023-04-11 Thread David Holmes
On Tue, 11 Apr 2023 13:40:39 GMT, Weijun Wang wrote: > Enhance the `Proc` utility to support compilation. test/lib/jdk/test/lib/process/Proc.java line 331: > 329: > 330: if (compile) { > 331: var comp = CompilerUtils.compile( I don't find this use of `var` helpful - `var`

Re: RFR: 8305846: Support compilation in Proc test utility

2023-04-11 Thread David Holmes
On Tue, 11 Apr 2023 13:40:39 GMT, Weijun Wang wrote: > Enhance the `Proc` utility to support compilation. test/lib/jdk/test/lib/process/Proc.java line 274: > 272: } > 273: // Compile as well > 274: public Proc compile() throws IOException { Why "throws IOException" ? I'm surprised