Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]

2023-05-31 Thread Alexey Semenyuk
On Wed, 31 May 2023 14:32:25 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The che

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]

2023-05-31 Thread Roger Riggs
On Wed, 31 May 2023 14:32:25 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The che

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v6]

2023-05-31 Thread Roger Riggs
> Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks of the os.version are replaced but may not be needed if

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v5]

2023-05-31 Thread Roger Riggs
> Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks of the os.version are replaced but may not be needed if

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v3]

2023-05-19 Thread Roger Riggs
On Thu, 18 May 2023 21:33:53 GMT, Alexey Semenyuk wrote: > > did we test jpackage on AIX system? > > I don't think so. What is the native packaging on this platform? To the best of my knowledge, AIX uses `installp` and `rpm`. - PR Comment: https://git.openjdk.org/jdk/pull/13586#is

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v4]

2023-05-19 Thread Roger Riggs
> Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks of the os.version are replaced but may not be needed if

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v3]

2023-05-18 Thread Alexey Semenyuk
On Thu, 18 May 2023 21:25:26 GMT, Alexander Matveev wrote: > did we test jpackage on AIX system? I don't think so. What is the native packaging on this platform? - PR Comment: https://git.openjdk.org/jdk/pull/13586#issuecomment-1553675715

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v3]

2023-05-18 Thread Alexander Matveev
On Mon, 15 May 2023 22:51:52 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The che

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v2]

2023-05-18 Thread Alexander Matveev
On Mon, 15 May 2023 20:10:38 GMT, Roger Riggs wrote: >> src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java line 51: >> >>> 49: Log.info(I18N.getString("MSG_Help_no_args")); >>> 50: } else { >>> 51: OperatingSystem platform = OperatingSystem.current(

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v3]

2023-05-18 Thread Glavo
On Mon, 15 May 2023 22:51:52 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The che

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v3]

2023-05-15 Thread Roger Riggs
> Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks of the os.version are replaced but may not be needed if

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v2]

2023-05-15 Thread Roger Riggs
On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The chec

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v2]

2023-05-15 Thread Roger Riggs
On Fri, 12 May 2023 22:04:24 GMT, Alexander Matveev wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor source code style cleanup > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java line 51: >

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v2]

2023-05-12 Thread Alexander Matveev
On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The chec

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v2]

2023-05-12 Thread Alexey Semenyuk
On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote: >> Refactor the Platform class in jdk.jpackage to use the internal >> OperatingSystem, Architecture, and Version classes. >> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace >> comparisons in the Platform class. >> The chec

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v2]

2023-05-05 Thread Roger Riggs
> Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks of the os.version are replaced but may not be needed if

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage

2023-05-05 Thread Andrey Turbanov
On Fri, 21 Apr 2023 17:28:54 GMT, Roger Riggs wrote: > Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks o

Re: RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage

2023-05-04 Thread Andrey Turbanov
On Fri, 21 Apr 2023 17:28:54 GMT, Roger Riggs wrote: > Refactor the Platform class in jdk.jpackage to use the internal > OperatingSystem, Architecture, and Version classes. > The OperatingSystem.isXXX() and Architecture.isYYY() methods replace > comparisons in the Platform class. > The checks o