Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-11 Thread Chen Liang
On Mon, 12 Jun 2023 04:52:57 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 103: >> >>> 101: } >>> 102: return descOrInternalName.substring(1, >>> descOrInternalName.length() - 1).replace('/', '.'); >>> 103: } els

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-11 Thread Chen Liang
On Mon, 12 Jun 2023 02:41:02 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 14 commits: >> >> - Review changes, fixed tests >> - Merge branch 'master' into hierarchy-resolve >> - 1. Moved the

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-11 Thread ExE Boss
On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-08 Thread ExE Boss
On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-08 Thread Chen Liang
On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-08 Thread Adam Sotona
On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v9]

2023-06-07 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a `Lookup`

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v8]

2023-06-07 Thread Chen Liang
On Fri, 2 Jun 2023 03:36:35 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v8]

2023-06-07 Thread Adam Sotona
On Fri, 2 Jun 2023 03:36:35 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v8]

2023-06-01 Thread Chen Liang
On Fri, 2 Jun 2023 03:36:35 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v8]

2023-06-01 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a `Lookup`

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v7]

2023-05-09 Thread Adam Sotona
On Tue, 9 May 2023 15:09:54 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is als

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v7]

2023-05-09 Thread Chen Liang
On Wed, 26 Apr 2023 09:47:58 GMT, Adam Sotona wrote: > > @asotona Just curious, what's the current state of our new API model of > > caching class hierarchy info in a Classfile context object as we've > > discussed on the mailing list? Will you create a patch, or should I update > > this patch

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v7]

2023-05-09 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a `Lookup`

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v6]

2023-04-26 Thread Adam Sotona
On Mon, 20 Mar 2023 15:21:57 GMT, Adam Sotona wrote: >> Marked as reviewed by asotona (Committer). > >> @asotona So should I simply throw an `IllegalAccessError` when the Lookup >> encounters a `IllegalAccessException`, or should I return null? I favor >> throwing an `IllegalAccessError` as the

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v6]

2023-04-25 Thread Chen Liang
On Mon, 20 Mar 2023 15:21:57 GMT, Adam Sotona wrote: >> Marked as reviewed by asotona (Committer). > >> @asotona So should I simply throw an `IllegalAccessError` when the Lookup >> encounters a `IllegalAccessException`, or should I return null? I favor >> throwing an `IllegalAccessError` as the

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v6]

2023-03-28 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a `Lookup`

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v5]

2023-03-28 Thread Adam Sotona
On Mon, 27 Mar 2023 14:34:06 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is al

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v5]

2023-03-28 Thread Adam Sotona
On Mon, 27 Mar 2023 14:34:06 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is al

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v5]

2023-03-27 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a `Lookup`

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v4]

2023-03-27 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a `Lookup`

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v3]

2023-03-20 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a `Lookup`

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v2]

2023-03-20 Thread Andrey Turbanov
On Mon, 20 Mar 2023 16:18:27 GMT, Chen Liang wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is al

Re: RFR: 8304425: ClassHierarchyResolver from Reflection [v2]

2023-03-20 Thread Chen Liang
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also useful to APIs that generate > bytecode with a `Lookup`

Re: RFR: 8304425: ClassHierarchyResolver from Reflection

2023-03-20 Thread Chen Liang
On Fri, 17 Mar 2023 18:18:48 GMT, Chen Liang wrote: > Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also us

Re: RFR: 8304425: ClassHierarchyResolver from Reflection

2023-03-20 Thread Adam Sotona
On Mon, 20 Mar 2023 11:07:23 GMT, Adam Sotona wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is a

Re: RFR: 8304425: ClassHierarchyResolver from Reflection

2023-03-20 Thread Chen Liang
On Mon, 20 Mar 2023 11:07:23 GMT, Adam Sotona wrote: >> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with >> proper privileges, with tests. >> >> This addition is useful in case classes at runtime are not loaded from the >> system class loader, such as Proxy. This is a

Re: RFR: 8304425: ClassHierarchyResolver from Reflection

2023-03-20 Thread Glavo
On Fri, 17 Mar 2023 18:18:48 GMT, Chen Liang wrote: > Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also us

Re: RFR: 8304425: ClassHierarchyResolver from Reflection

2023-03-20 Thread Adam Sotona
On Fri, 17 Mar 2023 18:18:48 GMT, Chen Liang wrote: > Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with > proper privileges, with tests. > > This addition is useful in case classes at runtime are not loaded from the > system class loader, such as Proxy. This is also us