Re: RFR: 8303002: Reject packed structs from linker [v7]

2023-04-27 Thread Jorn Vernee
> This patch adds checks in AbstractLinker to reject packed structs and structs > with excess padding (e.g. unnamed bitfields), since both of those are > currently not supported, and the ABI/spec seems too vague to base support on. Jorn Vernee has updated the pull request with a new target base

Re: RFR: 8303002: Reject packed structs from linker [v6]

2023-04-20 Thread Jorn Vernee
On Thu, 20 Apr 2023 09:27:40 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - restrictions -> characteristics >> - polish pt. 2 >> - polish wording >> - review comments > > Looks good.

Re: RFR: 8303002: Reject packed structs from linker [v6]

2023-04-20 Thread Maurizio Cimadamore
On Thu, 20 Apr 2023 01:12:44 GMT, Jorn Vernee wrote: >> This patch adds checks in AbstractLinker to reject packed structs and >> structs with excess padding (e.g. unnamed bitfields), since both of those >> are currently not supported, and the ABI/spec seems too vague to base >> support on. > >

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-19 Thread Jorn Vernee
On Thu, 20 Apr 2023 00:40:44 GMT, Jorn Vernee wrote: >> Also, isn't it the case that, for structs, we want the size of the layout to >> be a multiple of its alignment constraint? > > The third item in the list is for group size needing to be a multiple of the > alignment constraint, the forth i

Re: RFR: 8303002: Reject packed structs from linker [v6]

2023-04-19 Thread Jorn Vernee
> This patch adds checks in AbstractLinker to reject packed structs and structs > with excess padding (e.g. unnamed bitfields), since both of those are > currently not supported, and the ABI/spec seems too vague to base support on. Jorn Vernee has updated the pull request incrementally with four

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-19 Thread Jorn Vernee
On Tue, 18 Apr 2023 22:32:17 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-19 Thread Jorn Vernee
On Tue, 18 Apr 2023 22:26:03 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/foreign/Linker.java line 202: >> >>> 200: * Due to limited ABI specification coverage, all the native linker >>> implementations limit the function >>> 201: * descriptors that they support t

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-19 Thread Jorn Vernee
On Tue, 18 Apr 2023 22:17:02 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-18 Thread Maurizio Cimadamore
On Tue, 18 Apr 2023 13:45:57 GMT, Jorn Vernee wrote: >> This patch adds checks in AbstractLinker to reject packed structs and >> structs with excess padding (e.g. unnamed bitfields), since both of those >> are currently not supported, and the ABI/spec seems too vague to base >> support on. > >

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-18 Thread Maurizio Cimadamore
On Tue, 18 Apr 2023 22:25:09 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-18 Thread Maurizio Cimadamore
On Tue, 18 Apr 2023 13:45:57 GMT, Jorn Vernee wrote: >> This patch adds checks in AbstractLinker to reject packed structs and >> structs with excess padding (e.g. unnamed bitfields), since both of those >> are currently not supported, and the ABI/spec seems too vague to base >> support on. > >

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-18 Thread Maurizio Cimadamore
On Tue, 18 Apr 2023 13:45:57 GMT, Jorn Vernee wrote: >> This patch adds checks in AbstractLinker to reject packed structs and >> structs with excess padding (e.g. unnamed bitfields), since both of those >> are currently not supported, and the ABI/spec seems too vague to base >> support on. > >

Re: RFR: 8303002: Reject packed structs from linker [v5]

2023-04-18 Thread Jorn Vernee
> This patch adds checks in AbstractLinker to reject packed structs and structs > with excess padding (e.g. unnamed bitfields), since both of those are > currently not supported, and the ABI/spec seems too vague to base support on. Jorn Vernee has updated the pull request with a new target base

Re: RFR: 8303002: Reject packed structs from linker [v4]

2023-03-28 Thread Jorn Vernee
> This patch adds checks in AbstractLinker to reject packed structs and structs > with excess padding (e.g. unnamed bitfields), since both of those are > currently not supported, and the ABI/spec seems too vague to base support on. Jorn Vernee has updated the pull request with a new target base

Re: RFR: 8303002: Reject packed structs from linker [v2]

2023-03-28 Thread Jorn Vernee
On Mon, 27 Mar 2023 14:51:28 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. > > src/java.base/share/classes/java/lang/fore

Re: RFR: 8303002: Reject packed structs from linker [v2]

2023-03-28 Thread Jorn Vernee
On Tue, 28 Mar 2023 17:59:33 GMT, Jorn Vernee wrote: >> This patch adds checks in AbstractLinker to reject packed structs and >> structs with excess padding (e.g. unnamed bitfields), since both of those >> are currently not supported, and the ABI/spec seems too vague to base >> support on. > >

Re: RFR: 8303002: Reject packed structs from linker [v3]

2023-03-28 Thread Jorn Vernee
> This patch adds checks in AbstractLinker to reject packed structs and structs > with excess padding (e.g. unnamed bitfields), since both of those are > currently not supported, and the ABI/spec seems too vague to base support on. Jorn Vernee has updated the pull request incrementally with one

Re: RFR: 8303002: Reject packed structs from linker [v2]

2023-03-28 Thread Jorn Vernee
> This patch adds checks in AbstractLinker to reject packed structs and structs > with excess padding (e.g. unnamed bitfields), since both of those are > currently not supported, and the ABI/spec seems too vague to base support on. Jorn Vernee has updated the pull request with a new target base

Re: RFR: 8303002: Reject packed structs from linker

2023-03-27 Thread Maurizio Cimadamore
On Thu, 23 Mar 2023 18:11:18 GMT, Jorn Vernee wrote: > This patch adds checks in AbstractLinker to reject packed structs and structs > with excess padding (e.g. unnamed bitfields), since both of those are > currently not supported, and the ABI/spec seems too vague to base support on. src/java.