Re: RFR: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning [v2]

2023-03-02 Thread Alan Bateman
On Thu, 2 Mar 2023 17:43:54 GMT, Afshin Zafari wrote: >> ### Description >> The use of `ThreadDeath` is replaced with checking the exception be of type >> `Error` and the thread is `TERMINATED`. >> >> >> ### Test >> local and mach5 tier1 > > Afshin Zafari has updated the pull request increment

Re: RFR: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning [v2]

2023-03-02 Thread Afshin Zafari
On Thu, 2 Mar 2023 17:35:35 GMT, Alan Bateman wrote: >> I assumed the `ThreadDeath` was there to catch `Thread.stop()` calls and >> just ignore them. So, I wanted to keep this functionality. >> Can we remove using `ThreadDeath` relying on that `Thread.stop()` is also >> deprecated? > > I think

Re: RFR: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning [v2]

2023-03-02 Thread David Holmes
On Thu, 2 Mar 2023 17:43:54 GMT, Afshin Zafari wrote: >> ### Description >> The use of `ThreadDeath` is replaced with checking the exception be of type >> `Error` and the thread is `TERMINATED`. >> >> >> ### Test >> local and mach5 tier1 > > Afshin Zafari has updated the pull request increment

Re: RFR: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning [v2]

2023-03-02 Thread Afshin Zafari
> ### Description > The use of `ThreadDeath` is replaced with checking the exception be of type > `Error` and the thread is `TERMINATED`. > > > ### Test > local and mach5 tier1 Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision: 83016

Re: RFR: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning [v2]

2023-03-02 Thread Alan Bateman
On Thu, 2 Mar 2023 17:39:10 GMT, Afshin Zafari wrote: >> ### Description >> The use of `ThreadDeath` is replaced with checking the exception be of type >> `Error` and the thread is `TERMINATED`. >> >> >> ### Test >> local and mach5 tier1 > > Afshin Zafari has updated the pull request increment

Re: RFR: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning

2023-03-02 Thread Alan Bateman
On Thu, 2 Mar 2023 17:27:59 GMT, Afshin Zafari wrote: >> test/lib/jdk/test/lib/process/ProcessTools.java line 827: >> >>> 825: >>> 826: public void uncaughtException(Thread t, Throwable e) { >>> 827: if (e instanceof Error && t.getState() == >>> State.TERMINATED) { >> >> D

Re: RFR: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning

2023-03-02 Thread Afshin Zafari
On Thu, 2 Mar 2023 14:13:10 GMT, Alan Bateman wrote: >> ### Description >> The use of `ThreadDeath` is replaced with checking the exception be of type >> `Error` and the thread is `TERMINATED`. >> >> >> ### Test >> local and mach5 tier1 > > test/lib/jdk/test/lib/process/ProcessTools.java line

Re: RFR: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning

2023-03-02 Thread Alan Bateman
On Thu, 2 Mar 2023 12:15:21 GMT, Afshin Zafari wrote: > ### Description > The use of `ThreadDeath` is replaced with checking the exception be of type > `Error` and the thread is `TERMINATED`. > > > ### Test > local and mach5 tier1 test/lib/jdk/test/lib/process/ProcessTools.java line 827: > 8