On Wed, 25 Jan 2023 13:45:28 GMT, Severin Gehwolf wrote:
>> Please review this fix to
>> [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the
>> same handling for swap values exceeding what's possible in the non-container
>> case. I.e. treats it as unlimited and fixes the
On Wed, 25 Jan 2023 13:14:22 GMT, Thomas Stuefe wrote:
> Mostly good, small nits.
Thanks for the review, @tstuefe! I've updated the patch. Please let me know if
you want me to change anything else.
-
PR: https://git.openjdk.org/jdk/pull/12118
On Wed, 25 Jan 2023 13:22:45 GMT, Severin Gehwolf wrote:
>> src/java.base/linux/native/libjava/CgroupMetrics.c line 45:
>>
>>> 43: jlong pages = sysconf(_SC_PHYS_PAGES);
>>> 44: jlong page_size = sysconf(_SC_PAGESIZE);
>>> 45: return pages * page_size;
>>
>> Preexisting, and theoret
On Wed, 25 Jan 2023 13:45:28 GMT, Severin Gehwolf wrote:
>> Please review this fix to
>> [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the
>> same handling for swap values exceeding what's possible in the non-container
>> case. I.e. treats it as unlimited and fixes the
On Wed, 25 Jan 2023 13:14:22 GMT, Thomas Stuefe wrote:
> Mostly good, small nits.
Thanks for the review, @tstuefe! I've updated the patch. Please let me know if
you want me to change anything else.
-
PR: https://git.openjdk.org/jdk/pull/12118
On Wed, 25 Jan 2023 13:22:45 GMT, Severin Gehwolf wrote:
>> src/java.base/linux/native/libjava/CgroupMetrics.c line 45:
>>
>>> 43: jlong pages = sysconf(_SC_PHYS_PAGES);
>>> 44: jlong page_size = sysconf(_SC_PAGESIZE);
>>> 45: return pages * page_size;
>>
>> Preexisting, and theoret
On Wed, 25 Jan 2023 13:45:28 GMT, Severin Gehwolf wrote:
>> Please review this fix to
>> [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the
>> same handling for swap values exceeding what's possible in the non-container
>> case. I.e. treats it as unlimited and fixes the
> Please review this fix to
> [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the
> same handling for swap values exceeding what's possible in the non-container
> case. I.e. treats it as unlimited and fixes the reporting. This has been
> handled on the hotspot side similar
On Wed, 25 Jan 2023 13:08:28 GMT, Thomas Stuefe wrote:
> (I know you do an assert in java, but that has to be switched on explicitly -
> do we run tests with asserts enabled?)
Yes. That's why `-esa` is being added here:
https://github.com/openjdk/jdk/pull/12118/files#diff-597a72f91945acae784afe
On Wed, 25 Jan 2023 13:05:06 GMT, Thomas Stuefe wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> 8299858: [Metrics] Swap memory limit reported incorrectly when too large
>
> src/java.ba
On Wed, 25 Jan 2023 11:24:55 GMT, Severin Gehwolf wrote:
>> Please review this fix to
>> [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the
>> same handling for swap values exceeding what's possible in the non-container
>> case. I.e. treats it as unlimited and fixes the
> Please review this fix to
> [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the
> same handling for swap values exceeding what's possible in the non-container
> case. I.e. treats it as unlimited and fixes the reporting. This has been
> handled on the hotspot side similar
> Please review this fix to
> [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the
> same handling for swap values exceeding what's possible in the non-container
> case. I.e. treats it as unlimited and fixes the reporting. This has been
> handled on the hotspot side similar
On Fri, 20 Jan 2023 15:53:09 GMT, Severin Gehwolf wrote:
> Please review this fix to
> [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the
> same handling for swap values exceeding what's possible in the non-container
> case. I.e. treats it as unlimited and fixes the repo
14 matches
Mail list logo
