Re: RFR: 8298567: Make field in RandomAccessFile final [v3]

2022-12-12 Thread Per Minborg
> This PR proposes making a field in `RandomAccessFile` final. Also, it > modernises a switch statement. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove redundant check - Changes: - all: https://git.openjdk.org/

Re: RFR: 8298567: Make field in RandomAccessFile final [v2]

2022-12-12 Thread Chris Hegarty
On Mon, 12 Dec 2022 14:26:40 GMT, Per Minborg wrote: >> This PR proposes making a field in `RandomAccessFile` final. Also, it >> modernises a switch statement. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Make the field

Re: RFR: 8298567: Make field in RandomAccessFile final [v2]

2022-12-12 Thread Roger Riggs
On Mon, 12 Dec 2022 14:26:40 GMT, Per Minborg wrote: >> This PR proposes making a field in `RandomAccessFile` final. Also, it >> modernises a switch statement. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Make the field

Re: RFR: 8298567: Make field in RandomAccessFile final [v2]

2022-12-12 Thread Per Minborg
> This PR proposes making a field in `RandomAccessFile` final. Also, it > modernises a switch statement. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Make the field rw final - Changes: - all: https://git.openjdk.org

Re: RFR: 8298567: Make field in RandomAccessFile final

2022-12-12 Thread Alan Bateman
On Mon, 12 Dec 2022 12:48:47 GMT, Per Minborg wrote: > This PR proposes making a field in `RandomAccessFile` final. Also, it > modernises a switch statement. Surprising that RandomAccessFile.fd was not changed to final many years ago. We can do rw at the same time. - PR: https://