On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Tue, 8 Nov 2022 23:45:18 GMT, David Holmes wrote:
> "in the custom class loader must append to the class path in a thread-safe
> manner."
Maybe "its search path" rather than "the class path" because the custom class
loader can't add to the class path (the application class path continues to
On Tue, 8 Nov 2022 22:08:06 GMT, Coleen Phillimore wrote:
> in the custom class loader must synchronize appending to the class path
I would say:
"in the custom class loader must append to the class path in a thread-safe
manner."
-
PR: https://git.openjdk.org/jdk/pull/11023
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Tue, 8 Nov 2022 17:03:05 GMT, Coleen Phillimore wrote:
> Can one create a class loader to override this function, and does one expect
> the JVM to synchronize it on the system class loader object (returned by
> getSystemClassLoader)? This feels too remote to try to explain in a CSR.
>
> I'l
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Tue, 8 Nov 2022 04:23:13 GMT, David Holmes wrote:
> Note the loader involved need not be our own default platform loader and we
> don't know how a custom system loader might operate. The specification for
> this says nothing about thread-safety, nor that the VM will do any locking,
> so I t
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
> This patch moves the acquisition of the boot class loader lock out of the JVM
> and into the Java function.
> Tested with tier1-4, and jvmti and jdi tests locally.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
really revert
On Mon, 7 Nov 2022 19:04:36 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 19:00:40 GMT, Coleen Phillimore wrote:
> I reran jvmti tests on the change to revert ClassLoaders.java.
You can revert the comment too because it would be confusing to say that it
locks the class loader when it doesn't.
-
PR: https://git.openjdk.org/jdk/pull/110
On Mon, 7 Nov 2022 17:07:01 GMT, Coleen Phillimore wrote:
> This patch moves the acquisition of the boot class loader lock out of the JVM
> and into the Java function.
> Tested with tier1-4, and jvmti and jdi tests locally.
I reran jvmti tests on the change to revert ClassLoaders.java.
---
> This patch moves the acquisition of the boot class loader lock out of the JVM
> and into the Java function.
> Tested with tier1-4, and jvmti and jdi tests locally.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Revert ClassLo
On Mon, 7 Nov 2022 18:29:56 GMT, Alan Bateman wrote:
>> I traced it down to this: Is this why it's already synchronized ?
>> appendClassPath -> ucp.addFile -> addURL
>> public synchronized void addURL(URL url) {
>> if (closed || url == null)
>> return;
>>
On Mon, 7 Nov 2022 18:11:29 GMT, Coleen Phillimore wrote:
>> src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java line 204:
>>
>>> 202: * @see
>>> java.lang.instrument.Instrumentation#appendToSystemClassLoaderSearch
>>> 203: */
>>> 204: synchronized void a
25 matches
Mail list logo
