On Mon, 3 Oct 2022 21:22:03 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one a
On Tue, 4 Oct 2022 18:42:52 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/DigitList.java line 161:
>>
>>> 159: public final double getDouble() {
>>> 160: if (count == 0) {
>>> 161: return 0.0;
>>
>> The doc for this method is incorrect:
>>
>> * If (coun
On Tue, 4 Oct 2022 18:20:26 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove temp var
>>
>> Remove temp variables and replace with method chaining when possible
>
> src/java.base/share/
On Mon, 3 Oct 2022 21:22:03 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one a
On Mon, 3 Oct 2022 20:42:55 GMT, Jonathan Gibbons wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove comment typo
>> - Remove test wrapper
>
> src/java.base/share/classes/java/text/DigitList.java line 796:
>
>
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Remove temp va
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision:
- Remove comme
On Fri, 30 Sep 2022 16:52:40 GMT, Brent Christian wrote:
>> Due to some [bootstrapping
>> issues](https://stackoverflow.com/questions/71834059/why-invokedynamic-based-string-concatenation-is-not-available-for-javac-in-java)
>> in `java.base` explicit String concatenation is not translated into
On Fri, 30 Sep 2022 16:14:38 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/classes/java/text/PatternEntry.java line 291:
>>
>>> 289: // We re-use these objects in order to improve performance
>>> 290: private StringBuilder newChars = new StringBuilder();
>>> 291: priv
On Thu, 29 Sep 2022 22:29:43 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak indentation in PaternEntry
>
> src/java.base/share/classes/java/text/PatternEntry.java line 291:
>
>> 289:
On Fri, 30 Sep 2022 00:25:24 GMT, Lance Andersen wrote:
> > > Understand, I guess I don't see the difference from moving the tags to
> > > the actual test but there could be a subtlety I am missing (wouldn't be
> > > the first time ;-) )
> >
> >
> > The runner has a @library/@build tag to bui
On Thu, 29 Sep 2022 22:29:10 GMT, Naoto Sato wrote:
> > Understand, I guess I don't see the difference from moving the tags to the
> > actual test but there could be a subtlety I am missing (wouldn't be the
> > first time ;-) )
>
> The runner has a @library/@build tag to build the test case as
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Tweak indentat
On Thu, 29 Sep 2022 22:15:00 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one
On Thu, 29 Sep 2022 22:19:26 GMT, Lance Andersen wrote:
> Understand, I guess I don't see the difference from moving the tags to the
> actual test but there could be a subtlety I am missing (wouldn't be the first
> time ;-) )
The runner has a @library/@build tag to build the test case as a lib
On Thu, 29 Sep 2022 22:07:48 GMT, Naoto Sato wrote:
> AFAICT, the reason is described in the test class description, i.e., tweak to
> be in `java.text` package so that it can test the internal `hashCode` method.
Understand, I guess I don't see the difference from moving the tags to the
actual
On Thu, 29 Sep 2022 22:15:00 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Adjust typo wi
On Wed, 28 Sep 2022 22:54:33 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
AFAICT, the reason is described in the test class description, i.e., t
On Thu, 29 Sep 2022 21:49:05 GMT, Brent Christian wrote:
> > should we update
> > test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
> > to include `@test, @bug, @run, @summary`?
>
> ```
> /*
> (this test doesn't have an at-test tag because it's run by
> Bug4
On Thu, 29 Sep 2022 21:34:24 GMT, Lance Andersen wrote:
> should we update
> test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
> to include `@test, @bug, @run, @summary`?
Brent actually pointed that out to me as well. I believe since
Bug4170614Test.java is manag
On Thu, 29 Sep 2022 21:48:52 GMT, Justin Lu wrote:
> should we update
> test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
> to include `@test, @bug, @run, @summary`?
/*
(this test doesn't have an at-test tag because it's run by
Bug4170614TestRun.java
i
On Wed, 28 Sep 2022 22:54:33 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Looks good.
should we update
test/jdk/sun/text/IntHashtable/patch-sr
27 matches
Mail list logo
