Re: RFR: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl

2022-09-26 Thread Lance Andersen
On Sat, 17 Sep 2022 21:43:04 GMT, Andrey Turbanov wrote: > There a few unnecessary usages of StringBuffer in SQLOutputImpl class. > All of them create StringBuffer from single character and then concatenate > with String. Instead of this, we can concatenate character directly. The changes seem

Re: RFR: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl

2022-09-26 Thread Roger Riggs
On Mon, 26 Sep 2022 16:08:23 GMT, Andrey Turbanov wrote: >> src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java >> line 328: >> >>> 326: try { >>> 327: int i; >>> 328: while ((i = bufReader.read()) != -1) { >> >> Is the single character

Re: RFR: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl

2022-09-26 Thread Roger Riggs
On Sat, 17 Sep 2022 21:43:04 GMT, Andrey Turbanov wrote: > There a few unnecessary usages of StringBuffer in SQLOutputImpl class. > All of them create StringBuffer from single character and then concatenate > with String. Instead of this, we can concatenate character directly. Marked as reviewe

Re: RFR: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl

2022-09-26 Thread Andrey Turbanov
On Mon, 26 Sep 2022 14:53:24 GMT, Roger Riggs wrote: >> There a few unnecessary usages of StringBuffer in SQLOutputImpl class. >> All of them create StringBuffer from single character and then concatenate >> with String. Instead of this, we can concatenate character directly. > > src/java.sql.ro

Re: RFR: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl

2022-09-26 Thread Roger Riggs
On Sat, 17 Sep 2022 21:43:04 GMT, Andrey Turbanov wrote: > There a few unnecessary usages of StringBuffer in SQLOutputImpl class. > All of them create StringBuffer from single character and then concatenate > with String. Instead of this, we can concatenate character directly. src/java.sql.rows