Re: RFR: 8294271: make bootcycle-images fails after JDK-8289610

2022-09-23 Thread Aleksey Shipilev
On Fri, 23 Sep 2022 12:20:09 GMT, Jie Fu wrote: > > Fix is good but change bug type to subtask as Shipilev says. > > Done. Thanks @magicus and @shipilev . I think it is also better be named "Remove use of ThreadDeath from make utilities" :) - PR: https://git.openjdk.org/jdk/pull/

Re: RFR: 8294271: make bootcycle-images fails after JDK-8289610

2022-09-23 Thread Jie Fu
On Fri, 23 Sep 2022 12:09:46 GMT, Magnus Ihse Bursie wrote: > Fix is good but change bug type to subtask as Shipilev says. Done. Thanks @magicus and @shipilev . - PR: https://git.openjdk.org/jdk/pull/10406

Re: RFR: 8294271: make bootcycle-images fails after JDK-8289610

2022-09-23 Thread Magnus Ihse Bursie
On Fri, 23 Sep 2022 11:03:52 GMT, Jie Fu wrote: > Hi all, > > Since `ThreadDeath` would be deprecated soon, I assume it's fine to just > remove it. > > Thanks. > Best regards, > Jie Fix is good but change bug type to subtask as Shipilev says. In that case it sounds fine. I was worried you'd

Re: RFR: 8294271: make bootcycle-images fails after JDK-8289610

2022-09-23 Thread Aleksey Shipilev
On Fri, 23 Sep 2022 11:34:33 GMT, Aleksey Shipilev wrote: >> Hi all, >> >> Since `ThreadDeath` would be deprecated soon, I assume it's fine to just >> remove it. >> >> Thanks. >> Best regards, >> Jie > > This looks fine, and the current use of `ThreadDeath` does not even seem > correct (you h

Re: RFR: 8294271: make bootcycle-images fails after JDK-8289610

2022-09-23 Thread Magnus Ihse Bursie
On Fri, 23 Sep 2022 11:34:33 GMT, Aleksey Shipilev wrote: >> Hi all, >> >> Since `ThreadDeath` would be deprecated soon, I assume it's fine to just >> remove it. >> >> Thanks. >> Best regards, >> Jie > > This looks fine, and the current use of `ThreadDeath` does not even seem > correct (you h

Re: RFR: 8294271: make bootcycle-images fails after JDK-8289610

2022-09-23 Thread Aleksey Shipilev
On Fri, 23 Sep 2022 11:03:52 GMT, Jie Fu wrote: > Hi all, > > Since `ThreadDeath` would be deprecated soon, I assume it's fine to just > remove it. > > Thanks. > Best regards, > Jie This looks fine, and the current use of `ThreadDeath` does not even seem correct (you have to rethrow it). But