Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-24 Thread Alan Bateman
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-21 Thread Magnus Ihse Bursie
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-21 Thread Kevin Rushforth
On Wed, 21 Sep 2022 08:35:30 GMT, Magnus Ihse Bursie wrote: > While this particular issue was closed now, this is perhaps yet another > indication that the "import modules" thing is causing problems, and should be > removed now that it is not used anymore. I created > [JDK-8294095](https://bug

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-21 Thread Magnus Ihse Bursie
On Tue, 20 Sep 2022 12:35:58 GMT, Alan Bateman wrote: >> I haven't built a JDK using the `--with-import-modules` to include the >> `javafx.*` modules in quite a while, but my recollection is that yes, that >> did cause the JavaFX modules to be loaded by the platform class loader. The >> follow

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-21 Thread Leslie Zhai
On Tue, 20 Sep 2022 14:11:55 GMT, Kevin Rushforth wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug >> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` fa

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-21 Thread dumasun
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-20 Thread Leslie Zhai
On Tue, 20 Sep 2022 14:11:55 GMT, Kevin Rushforth wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug >> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` fa

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-20 Thread Kevin Rushforth
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-20 Thread Alan Bateman
On Tue, 20 Sep 2022 12:27:39 GMT, Kevin Rushforth wrote: > I haven't built a JDK using the `--with-import-modules` to include the > `javafx.*` modules in quite a while, but my recollection is that yes, that > did cause the JavaFX modules to be loaded by the platform class loader. The > followi

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-20 Thread Kevin Rushforth
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-20 Thread Alan Bateman
On Tue, 20 Sep 2022 08:04:48 GMT, dumasun wrote: > I donot edit make/conf/module-loader-map.conf. @magicus @kevinrushforth In the distant past, the javafx.* modules were mapped to the platform class loader. Do you recall how that worked with configure --with-import-modules? If someone uses jl

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-20 Thread dumasun
On Tue, 20 Sep 2022 06:12:06 GMT, Alan Bateman wrote: > > jtreg/bin/jtreg -dir:test/jdk > > -testjdk:./jdk-fx-jdk-20+15-56-g4020ed53dd6-linux_x64 > > -verbose:all jdk/modules/etc/VerifyModuleDelegation.java > > Is jdk-fx-jdk-20+15-56-g4020ed53dd6-linux_x64 your build or is it coming from > so

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-19 Thread Alan Bateman
On Mon, 19 Sep 2022 11:53:19 GMT, dumasun wrote: > jtreg/bin/jtreg -dir:test/jdk > -testjdk:./jdk-fx-jdk-20+15-56-g4020ed53dd6-linux_x64 \ > -verbose:all jdk/modules/etc/VerifyModuleDelegation.java Is jdk-fx-jdk-20+15-56-g4020ed53dd6-linux_x64 your build or is it coming from somewhere else? Al

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-19 Thread dumasun
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-19 Thread Alan Bateman
On Mon, 19 Sep 2022 07:02:40 GMT, Leslie Zhai wrote: > java.lang.Error: platform/javafx.swing can't delegate to find classes from > app/jdk.unsupported.desktop There must be configuration somewhere that is mapping the javafx.* modules to the platform class loader So I think the test is doing i

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-19 Thread Leslie Zhai
On Mon, 19 Sep 2022 06:14:25 GMT, Alan Bateman wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug >> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` faile

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

2022-09-18 Thread Alan Bateman
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --