On Tue, 13 Sep 2022 17:35:45 GMT, Aleksey Shipilev wrote:
>> Here is where we get into a minor pickle. We currently default to
>> `Deflater.DEFAULT_COMPRESSION`, which is `-1`, and which is handled inside
>> `zlib` as `6`. We can say `zip-6` here is the default, but that would be
>> stale if z
On Tue, 13 Sep 2022 17:21:52 GMT, Aleksey Shipilev wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties line 87:
>>
>>> 85: main.opt.compress=Compression to use when creating the JMOD archive.\
>>> 86: \ Accepted values are: zip-[0-9], where zip-0 provides no compressio
On Tue, 13 Sep 2022 16:51:52 GMT, Mandy Chung wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More review comments
>
> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties line 87:
>
>> 85: mai
On Tue, 13 Sep 2022 09:31:49 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Tue, 13 Sep 2022 09:31:49 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> without a heavy loss in *.jmod sizes.
>
> This PR allows JMO
