On Fri, 16 Sep 2022 08:03:28 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Fri, 16 Sep 2022 08:03:28 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Fri, 16 Sep 2022 08:03:28 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Fri, 16 Sep 2022 08:03:28 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Tue, 13 Sep 2022 17:41:04 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> without a heavy loss in *.jmod sizes.
>
> This PR allows JMO
On Tue, 13 Sep 2022 17:41:04 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Wed, 14 Sep 2022 01:05:35 GMT, Jaikiran Pai wrote:
> Hello Aleksey, could you also please create a release note for this? You may
> already know how to do that, if not, the steps are noted here
> https://openjdk.org/guide/#release-notes
Yes, but later, once CSR and this PR integrates in its
On Tue, 13 Sep 2022 17:41:04 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Tue, 13 Sep 2022 17:35:45 GMT, Aleksey Shipilev wrote:
>> Here is where we get into a minor pickle. We currently default to
>> `Deflater.DEFAULT_COMPRESSION`, which is `-1`, and which is handled inside
>> `zlib` as `6`. We can say `zip-6` here is the default, but that would be
>> stale if z
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> without a heavy loss in *.jmod sizes.
>
> This PR allows JMO
On Tue, 13 Sep 2022 17:21:52 GMT, Aleksey Shipilev wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties line 87:
>>
>>> 85: main.opt.compress=Compression to use when creating the JMOD archive.\
>>> 86: \ Accepted values are: zip-[0-9], where zip-0 provides no compressio
On Tue, 13 Sep 2022 16:51:52 GMT, Mandy Chung wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More review comments
>
> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties line 87:
>
>> 85: mai
On Tue, 13 Sep 2022 09:31:49 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Tue, 13 Sep 2022 09:28:07 GMT, Aleksey Shipilev wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java line 1196:
>>
>>> 1194: }
>>> 1195: try {
>>> 1196: int level = Integer.parseInt(value.substring(idx +
>>> 1));
>>
>> If I'm reading thi
On Tue, 13 Sep 2022 09:31:49 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Tue, 13 Sep 2022 08:10:28 GMT, Jaikiran Pai wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More review comments
>
> src/jdk.jlink/share/classes/jdk/tools/jmod/JmodOutputStream.java line 66:
>
>> 64: pr
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> without a heavy loss in *.jmod sizes.
>
> This PR allows JMO
On Tue, 13 Sep 2022 07:42:33 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Mon, 12 Sep 2022 18:51:28 GMT, Mandy Chung wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adopt "--compress zip-[0-9]" as option format
>
> src/jdk.jlink/share/classes/jdk/tools/jmod/JmodOutputStream.java l
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> without a heavy loss in *.jmod sizes.
>
> This PR allows JMO
On Mon, 12 Sep 2022 18:34:12 GMT, Aleksey Shipilev wrote:
>> I have been looking into `make clean-images images` performance, and
>> realized jmod keeps compressing files with default compression level. Tuning
>> that toward lighter compression levels improves build performance
>> considerably
On Mon, 12 Sep 2022 10:58:41 GMT, Jaikiran Pai wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
On Mon, 12 Sep 2022 15:51:25 GMT, Mark Reinhold wrote:
> Agreed. With this approach we can also revise `jlink --compress` to take the
> same arguments, keeping `[012]` for compatibility. We can also name this
> option `--compress` for `jmod`, rather than `--compression-level`, for
> consistenc
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> without a heavy loss in *.jmod sizes.
>
> This PR allows JMO
25 matches
Mail list logo
