Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-08-03 Thread Naoto Sato
On Wed, 3 Aug 2022 14:08:26 GMT, Ichiroh Takiguchi wrote: > I'm not sure if this change will solve the reporter's issue... It does solve the submitter's issue. With this fix: jshell> HexFormat.ofDelimiter(" ").formatHex("<%adc".getBytes("IBM864")) $181 ==> "3c 25 61 64 63" which is exactly th

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-08-03 Thread Ichiroh Takiguchi
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. I think you can ignore my comments. I'm not sure if this change will solve the reporter's issue... -

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-08-02 Thread Alan Bateman
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9661

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-08-02 Thread Naoto Sato
On Tue, 2 Aug 2022 08:35:51 GMT, Alan Bateman wrote: >> Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy >> came from the mapping difference between MS and IBM. > > test/jdk/java/beans/XMLEncoder/Test4625418.java line 26: > >> 24: /* >> 25: * @test >> 26: * @bug 46

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-08-02 Thread Alan Bateman
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. test/jdk/java/beans/XMLEncoder/Test4625418.java line 26: > 24: /* > 25: * @test > 26: * @bug 4625418 82399

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-07-29 Thread Naoto Sato
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. Sorry, but I don't have any intention to change the current roundtrip behavior of 0x25 <-> U+066A in Cp/IBM8

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-07-28 Thread Ichiroh Takiguchi
On Thu, 28 Jul 2022 16:18:51 GMT, Naoto Sato wrote: >> Many thanks @naotoj . >> >> I checked the latest IBM-864 mapping table. >> (I assume current OpenJDK's IBM864 may refer older mapping table) >> https://raw.githubusercontent.com/unicode-org/icu/main/icu4c/source/data/mappings/ibm-864_X110-19

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-07-28 Thread Joe Wang
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9661

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-07-28 Thread Naoto Sato
On Thu, 28 Jul 2022 10:29:07 GMT, Ichiroh Takiguchi wrote: >> @takiguc Sure. Appreciate it. > > Many thanks @naotoj . > > I checked the latest IBM-864 mapping table. > (I assume current OpenJDK's IBM864 may refer older mapping table) > https://raw.githubusercontent.com/unicode-org/icu/main/icu4

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-07-28 Thread Ichiroh Takiguchi
On Thu, 28 Jul 2022 01:46:26 GMT, Naoto Sato wrote: >> Hello @naotoj . >> I'm not reviewer, but I'd like to test this change. >> Could you wait for a moment ? >> Thanks. > > @takiguc Sure. Appreciate it. Many thanks @naotoj . I checked the latest IBM-864 mapping table. (I assume current OpenJDK

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-07-27 Thread Naoto Sato
On Thu, 28 Jul 2022 00:58:59 GMT, Ichiroh Takiguchi wrote: >> Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy >> came from the mapping difference between MS and IBM. > > Hello @naotoj . > I'm not reviewer, but I'd like to test this change. > Could you wait for a mom

Re: RFR: 8290488: IBM864 character encoding implementation bug

2022-07-27 Thread Ichiroh Takiguchi
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. Hello @naotoj . I'm not reviewer, but I'd like to test this change. Could you wait for a moment ? Thanks. --