On Mon, 18 Jul 2022 14:02:47 GMT, Ryan Ernst wrote:
>> This commit guards uses of Files methods returning path streams in
>> java.base to use try-with-resources.
>
> Ryan Ernst has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix compile and
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
Ryan Ernst has updated the pull request incrementally with one additional
commit since the last revision:
fix compile and address more feedback
-
Changes:
- all: https://
On Sat, 16 Jul 2022 03:35:06 GMT, Bernd wrote:
>> Ryan Ernst has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address formatting feedback
>
> src/java.base/share/classes/java/time/chrono/HijrahChronology.java line 1041:
>
>> 1039:
On Fri, 15 Jul 2022 19:33:56 GMT, Ryan Ernst wrote:
>> This commit guards uses of Files methods returning path streams in
>> java.base to use try-with-resources.
>
> Ryan Ernst has updated the pull request incrementally with one additional
> commit since the last revision:
>
> address formatt
On Fri, 15 Jul 2022 19:33:56 GMT, Ryan Ernst wrote:
>> This commit guards uses of Files methods returning path streams in
>> java.base to use try-with-resources.
>
> Ryan Ernst has updated the pull request incrementally with one additional
> commit since the last revision:
>
> address formatt
On Fri, 15 Jul 2022 16:06:21 GMT, Ryan Ernst wrote:
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
Thanks Alan. The 8 space indents were unintentional. I think I've addressed all
your comments in
[c0a09f9](https://github.com/openjdk/
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
Ryan Ernst has updated the pull request incrementally with one additional
commit since the last revision:
address formatting feedback
-
Changes:
- all: https://git.openjd
On Fri, 15 Jul 2022 16:06:21 GMT, Ryan Ernst wrote:
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
src/java.base/share/classes/jdk/internal/module/ModuleHashes.java line 119:
> 117: }
> 118: try {
> 119: by
On Fri, 15 Jul 2022 16:06:21 GMT, Ryan Ernst wrote:
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
Changing these usages to close the stream is good but needs to keep the
formatting/style consistent with the existing code. Also can yo
