Re: RFR: 8288933: Improve the implementation of Double/Float.isInfinite

2022-09-09 Thread Joe Darcy
On Wed, 22 Jun 2022 12:43:53 GMT, Quan Anh Mai wrote: > Improve the implementation of `Double/Float.isInfinite` to reduce branching. > Using `>` comparison with `MAX_VALUE` instead of `==` with > `POSITIVE_INFINITY` improves code emission on x86 and produces similar code > for arm. This is als

Re: RFR: 8288933: Improve the implementation of Double/Float.isInfinite

2022-09-09 Thread Quan Anh Mai
On Sun, 17 Jul 2022 10:58:45 GMT, Claes Redestad wrote: >> @merykitty, the proposed change is functionally correct. >> >> @cl4es, what set of platforms do we usually consider for evaluating >> performance changes like this? > >> @cl4es, what set of platforms do we usually consider for evaluatin

Re: RFR: 8288933: Improve the implementation of Double/Float.isInfinite

2022-09-09 Thread Claes Redestad
On Wed, 22 Jun 2022 12:43:53 GMT, Quan Anh Mai wrote: > Improve the implementation of `Double/Float.isInfinite` to reduce branching. > Using `>` comparison with `MAX_VALUE` instead of `==` with > `POSITIVE_INFINITY` improves code emission on x86 and produces similar code > for arm. This is als

Re: RFR: 8288933: Improve the implementation of Double/Float.isInfinite

2022-08-23 Thread Quan Anh Mai
On Wed, 22 Jun 2022 12:43:53 GMT, Quan Anh Mai wrote: > Improve the implementation of `Double/Float.isInfinite` to reduce branching. > Using `>` comparison with `MAX_VALUE` instead of `==` with > `POSITIVE_INFINITY` improves code emission on x86 and produces similar code > for arm. This is als

Re: RFR: 8288933: Improve the implementation of Double/Float.isInfinite

2022-07-17 Thread Quan Anh Mai
On Sun, 17 Jul 2022 10:58:45 GMT, Claes Redestad wrote: >> @merykitty, the proposed change is functionally correct. >> >> @cl4es, what set of platforms do we usually consider for evaluating >> performance changes like this? > >> @cl4es, what set of platforms do we usually consider for evaluatin

Re: RFR: 8288933: Improve the implementation of Double/Float.isInfinite

2022-07-17 Thread Claes Redestad
On Thu, 14 Jul 2022 05:17:09 GMT, Joe Darcy wrote: > @cl4es, what set of platforms do we usually consider for evaluating > performance changes like A mix of x86 and aarch64 systems, some old, some new. We could run the microbenchmark on our internal performance system to verify the reported

Re: RFR: 8288933: Improve the implementation of Double/Float.isInfinite

2022-07-13 Thread Joe Darcy
On Wed, 22 Jun 2022 12:43:53 GMT, Quan Anh Mai wrote: > Improve the implementation of `Double/Float.isInfinite` to reduce branching. > Using `>` comparison with `MAX_VALUE` instead of `==` with > `POSITIVE_INFINITY` improves code emission on x86 and produces similar code > for arm. This is als