Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Paul Hohensee
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. I assumed it was a starter issue in order to learn the patch process. - PR: https://git.openjdk.org/jdk/pull/8179

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Roger Riggs
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. I see this one languished quite a while without a review. Sorry about that; for the uninteresting, maybe it really is insufficiently interesting to even pursue except as a starter issue

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Roger Riggs
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. For some new features, its an obvious yes, though personally, it should add some value to the code, not just churn the code base to be up-to-date. Also, there is quite a bit of core cod

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Volker Simonis
On Tue, 28 Jun 2022 16:54:54 GMT, Roger Riggs wrote: >> Changes the definition of `CollectorImpl` to be a record. > > Marked as reviewed by rriggs (Reviewer). Hi @RogerRiggs, Thanks for reviewing this PR. I have a more general question. Do we have any recommendations about using new language f

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Roger Riggs
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.org/jdk/pull/8179

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Paul Hohensee
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. I believe we need another reviewer (doesn't have to be a capital-Reviewer). I'll sponsor after that. - PR: https://git.openjdk.org/jdk/pull/8179

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread altrisi
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. Thanks for the review! - PR: https://git.openjdk.org/jdk/pull/8179

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Paul Hohensee
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. Lgtm. - Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk/pull/8179

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-27 Thread altrisi
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. Hi, is this small PR missing anything in order to be reviewed? Thanks! - PR: https://git.openjdk.org/jdk/pull/8179