Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Alan Bateman
On Fri, 16 Jun 2023 11:09:23 GMT, Sean Coffey wrote: > Logged https://bugs.openjdk.org/browse/JDK-8310201 to track the Locale > changes Alan. Thanks, probably should treat this as a bug for JDK 21 so that a new addition doesn't change behavior between 21 and 22. - PR Review Comme

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Sean Coffey
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Sean Coffey
On Wed, 14 Jun 2023 14:06:33 GMT, Sean Mullan wrote: >> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 424: >> >>> 422:if (!services.isEmpty()) { >>> 423:services.stream() >>> 424: >>> .sorted(Comparator.comparing

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Sean Coffey
On Thu, 15 Jun 2023 06:32:06 GMT, Alan Bateman wrote: >> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 183: >> >>> 181: case "locale": >>> 182: printLocale(); >>> 183: break; >> >> printLocale might need the same treatment to avoid

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-16 Thread Sean Coffey
On Wed, 14 Jun 2023 12:46:36 GMT, Weijun Wang wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate review comments from Roger and tweak some code > > src/java.base/share/classes/sun/launcher/LauncherHelper.ja

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-15 Thread Alan Bateman
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Alan Bateman
On Thu, 15 Jun 2023 06:29:09 GMT, Alan Bateman wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate review comments from Roger and tweak some code > > src/java.base/share/classes/sun/launcher/LauncherHelper.j

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Alan Bateman
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Anthony Scarpino
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Sean Mullan
On Wed, 14 Jun 2023 11:52:35 GMT, Weijun Wang wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate review comments from Roger and tweak some code > > src/java.base/share/classes/sun/launcher/LauncherHelper.ja

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Weijun Wang
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Weijun Wang
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Weijun Wang
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote: >> New functionality in the -XshowSettings menu to display relevant information >> about JDK security configuration > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > Incorp

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

2023-06-14 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Incorporate review comments from Roger and tweak some code