On Fri, 9 Sep 2022 10:03:11 GMT, Markus KARG wrote:
>> Unless there's a bug and the new code path is triggered when there's a mark
>> ;-) . Maybe we can convince ourselves that this can't happen now (by reading
>> the code), but if someone modifies this code 2 years from now and introduces
>>
On Fri, 9 Sep 2022 08:49:07 GMT, Daniel Fuchs wrote:
>> I did not do that so far, as we agreed to check the *new* code path, which
>> is only executed when noting was marked (so reset plays no role). Certainly
>> I will be happy to add another test for the use case you describe (i. e. the
>> *
On Fri, 9 Sep 2022 06:45:04 GMT, Markus KARG wrote:
>> test/jdk/java/io/BufferedInputStream/TransferTo.java line 170:
>>
>>> 168: if (mark) {
>>> 169: in.mark(1);
>>> 170: }
>>
>> This just tests transferTo with a mark set, it doesn't appear to check that
On Fri, 9 Sep 2022 06:36:54 GMT, Alan Bateman wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - testing transferTo() when mark was set
>> - testing transferTo() when buffer is non-empty
>
> test/jdk/java/io/Buffere
On Thu, 8 Sep 2022 08:26:43 GMT, Markus KARG wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - testing transferTo() when mark was set
> - testing transferTo() when buffer is non-empty
> Implementation of JDK-8279283
Markus KARG has updated the pull request incrementally with two additional
commits since the last revision:
- testing transferTo() when mark was set
- testing transferTo() when buffer is non-empty
-
Changes:
- all: https://git.openjdk.org/jdk/pul
