> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Correct Label annontation capitals
-
Changes:
- all: https://git.openjdk
On Mon, 19 Sep 2022 16:55:01 GMT, Sean Coffey wrote:
>> Plus one regarding "too much noise". This event is at the
>> Provider.getService() level and would reports all calls regardless the type
>> and algorithm. Crypto services which supports the delayed provider selection
>> may call Provider.
On Mon, 19 Sep 2022 16:12:18 GMT, Sean Coffey wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update from review com
On Mon, 19 Sep 2022 16:12:18 GMT, Sean Coffey wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update from review com
On Mon, 19 Sep 2022 16:43:26 GMT, Valerie Peng wrote:
>> Yes, I think this would generate too much noise and detract from the main
>> motivation for these events, which is to help users analyze the security of
>> algorithms that are being used by their applications at the JCE layer.
>
> Plus on
On Mon, 19 Sep 2022 15:52:08 GMT, Sean Mullan wrote:
>> I had this as the original design actually. I'm not sure how interesting it
>> would be to record such "no-service" type events. It would probably add 2-4
>> times the number of events for this event type to a typical recording, given
>>
On Mon, 19 Sep 2022 15:46:46 GMT, Sean Coffey wrote:
> This new event is disabled by default just like the other crypto related
> events that were added some time back (e.g. `TLSHandshakeEvent`). My
> assumption is that these events will be enabled for audit mode when one is
> interested in fi
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
update from review comments
-
Changes:
- all: https://git.openjdk.org/jd
On Mon, 19 Sep 2022 15:25:43 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/java/security/Provider.java line 1293:
>>
>>> 1291: }
>>> 1292:
>>> 1293: if (s != null && SecurityProviderServiceEvent.isTurnedOn()) {
>>
>> Would it be useful to generate an event even for the
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
>
This new event is disabled by default just like the other crypto related events
that were added some time back (e.g. `TLSHandshakeEvent`).
On Mon, 19 Sep 2022 14:25:55 GMT, Jaikiran Pai wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> src/java.base/share/classes/java/security/Provider.java line 1293:
>
>> 1291: }
>> 1292:
>> 1293: if (s != null && Secur
On Mon, 19 Sep 2022 15:27:05 GMT, Sean Coffey wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 32:
>>
>>> 30:
>>> 31: import jdk.jfr.Event;
>>> 32: import jdk.jfr.events.*;
>>
>> Hello Sean, rest of the changes look fine to me, except this one. Was this
>> a
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
src/java.base/share/classes/java/security/Provider.java line 1293:
> 1291: }
> 1292:
> 1293: if (s != null && SecurityProvider
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
I noticed that the event is disabled by default.
Is it because of concerns of too many events, or too much overhead? Or
something else?
I thi
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
The failures reported in the GitHub Actions job look related to this change -
`jdk.jfr.event.metadata.TestDefaultConfigurations` test appears t
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Looks good.
-
Marked as reviewed by mullan (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9657
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Reviewer request: @seanjmullan @egahlin
-
PR: https://git.openjdk.org/jdk/pull/9657
17 matches
Mail list logo
