Re: RFR: 8240567: SystemModulesPlugin: Keep stack clean

2023-04-16 Thread Alan Bateman
On Wed, 12 Apr 2023 10:05:34 GMT, Oliver Kopp wrote: > For me, it's the correct one. I was not sure which one to link. I can also > drop the reference. I checked the generated code and it looks like the code generated to invoke builder's newRequires, newExports, ... is missing a pop as the ret

Re: RFR: 8240567: SystemModulesPlugin: Keep stack clean

2023-04-12 Thread Oliver Kopp
On Wed, 12 Apr 2023 09:43:11 GMT, Alan Bateman wrote: > I think you've got the wrong JBS issue, JDK-8240567 is about changing the > SystemModulesPlugin to avoid the 64k limit on method size. For me, it's the correct one. I was not sure which one to link. I can also drop the reference. More ba

Re: RFR: 8240567: SystemModulesPlugin: Keep stack clean

2023-04-12 Thread Alan Bateman
On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp wrote: > This refs [https://bugs.openjdk.org/browse/JDK-82405679](8240567). Does NOT > fix it, but cleanup `SystemModulesPlugin` a bit to ease working on the bug > itself. > > Although this change is rather small, I think, it's good to have a "more