Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2023-06-16 Thread Alan Bateman
On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman wrote: >> Oliver Kopp has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2023-06-16 Thread Oliver Kopp
On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman wrote: >> Oliver Kopp has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2023-06-16 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods > >

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2022-10-16 Thread Alan Bateman
On Mon, 17 Oct 2022 06:37:24 GMT, Jaikiran Pai wrote: > Looking at the existing code (without the proposed changes in this PR), it > appears that it's not just the number of `moduleInfos` that could impact the > method size but even details like `requires`, `exports`, `opens` and other > such

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2022-10-16 Thread Jaikiran Pai
On Fri, 14 Oct 2022 23:12:38 GMT, Oliver Kopp wrote: >> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): >> "MethodTooLargeException thrown while creating a jlink image". >> >> Java still has a 64kb limit: A method may not be longer than 64kb. The idea >> of the fix is to sp

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2022-10-16 Thread Jaikiran Pai
On Fri, 14 Oct 2022 23:12:38 GMT, Oliver Kopp wrote: >> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): >> "MethodTooLargeException thrown while creating a jlink image". >> >> Java still has a 64kb limit: A method may not be longer than 64kb. The idea >> of the fix is to sp

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v4]

2022-10-14 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods Oli