Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v8]

2024-12-10 Thread Viktor Klang
On Wed, 27 Nov 2024 16:01:53 GMT, Michel Charpentier wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing review feedback > > I just noticed this improved performance in Java 23. However, it still > doesn't

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v8]

2024-12-06 Thread Michel Charpentier
On Sat, 13 Apr 2024 14:27:12 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v8]

2024-04-15 Thread Paul Sandoz
On Sat, 13 Apr 2024 14:27:12 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v8]

2024-04-13 Thread Viktor Klang
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this PR (on my MacBook, aarch64): > > Non-short-circuiting:

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v7]

2024-04-13 Thread Viktor Klang
On Sat, 13 Apr 2024 09:20:17 GMT, Rémi Forax wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding additional, short-circuit-specific, cases to the FlatMap benchmark > > Hello, i will not pretend I fully understan

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v7]

2024-04-13 Thread Viktor Klang
On Sat, 13 Apr 2024 09:04:36 GMT, Rémi Forax wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding additional, short-circuit-specific, cases to the FlatMap benchmark > > src/java.base/share/classes/java/util/strea

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v7]

2024-04-13 Thread Rémi Forax
On Fri, 12 Apr 2024 14:53:01 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v7]

2024-04-13 Thread Rémi Forax
On Fri, 12 Apr 2024 14:53:01 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v7]

2024-04-13 Thread Rémi Forax
On Fri, 12 Apr 2024 14:53:01 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v7]

2024-04-12 Thread Paul Sandoz
On Fri, 12 Apr 2024 14:53:01 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v7]

2024-04-12 Thread Viktor Klang
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this PR (on my MacBook, aarch64): > > Non-short-circuiting:

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams

2024-04-12 Thread Viktor Klang
On Mon, 8 Apr 2024 16:47:24 GMT, Paul Sandoz wrote: >> @PaulSandoz @AlanBateman I've added a commit to this PR which removes the >> use of Gatherer for Stream::flatMap, but instead implements flatMap for all >> of the pipelines using the same encoding which Gatherer would use. It seems >> very

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v6]

2024-04-12 Thread Viktor Klang
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this PR: > > Benchmark(size) Mode Cnt

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v5]

2024-04-11 Thread Viktor Klang
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this PR: > > Benchmark(size) Mode Cnt

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v4]

2024-04-11 Thread Viktor Klang
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this PR: > > Benchmark(size) Mode Cnt

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v3]

2024-04-10 Thread Viktor Klang
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this PR: > > Benchmark(size) Mode Cnt

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v2]

2024-04-09 Thread Paul Sandoz
On Tue, 9 Apr 2024 10:07:46 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v2]

2024-04-09 Thread Viktor Klang
On Tue, 9 Apr 2024 10:04:44 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v2]

2024-04-09 Thread Viktor Klang
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this PR: > > > Benchmark(size) Mode Cnt

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams

2024-04-09 Thread Viktor Klang
On Thu, 4 Apr 2024 12:18:07 GMT, Viktor Klang wrote: > This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this P

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams

2024-04-09 Thread Viktor Klang
On Mon, 8 Apr 2024 16:47:24 GMT, Paul Sandoz wrote: > > @PaulSandoz @AlanBateman I've added a commit to this PR which removes the > > use of Gatherer for Stream::flatMap, but instead implements flatMap for all > > of the pipelines using the same encoding which Gatherer would use. It seems > >

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams

2024-04-09 Thread Paul Sandoz
On Mon, 8 Apr 2024 10:20:11 GMT, Viktor Klang wrote: > @PaulSandoz @AlanBateman I've added a commit to this PR which removes the use > of Gatherer for Stream::flatMap, but instead implements flatMap for all of > the pipelines using the same encoding which Gatherer would use. It seems very > co

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams

2024-04-09 Thread Viktor Klang
On Thu, 4 Apr 2024 12:18:07 GMT, Viktor Klang wrote: > This PR implements Gatherer-inspired encoding of `flatMap` that shows that it > is both competitive performance-wise as well as improve correctness. > > Below is the performance of `Stream::flatMap` (for reference types): > > Before this P