Re: RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v4]

2023-07-19 Thread Naoto Sato
On Wed, 19 Jul 2023 19:41:57 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197) >> which updates the javadoc for the constructor of MessageFormat regarding a >> `null` locale, >> >> `MessageFormat` when created with a `null` locale may throw a

Re: RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v4]

2023-07-19 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197) > which updates the javadoc for the constructor of MessageFormat regarding a > `null` locale, > > `MessageFormat` when created with a `null` locale may throw a > `NullPointerException` either during the object creati

Re: RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v3]

2023-07-19 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197) > which updates the javadoc for the constructor of MessageFormat regarding a > `null` locale, > > `MessageFormat` when created with a `null` locale may throw a > `NullPointerException` either during the object creati

Re: RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v2]

2023-07-19 Thread Justin Lu
On Tue, 18 Jul 2023 22:09:48 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Slight wording adjustment >> - Review: Explicitly declare when NPE thrown instead of 'may' > > src/java.base/share/classe

Re: RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v2]

2023-07-18 Thread Naoto Sato
On Tue, 18 Jul 2023 20:48:13 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197) >> which updates the javadoc for the constructor of MessageFormat regarding a >> `null` locale, >> >> `MessageFormat` when created with a `null` locale may throw a

Re: RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v2]

2023-07-18 Thread Justin Lu
On Mon, 17 Jul 2023 21:54:37 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Slight wording adjustment >> - Review: Explicitly declare when NPE thrown instead of 'may' > > src/java.base/share/classe

Re: RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v2]

2023-07-18 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197) > which updates the javadoc for the constructor of MessageFormat regarding a > `null` locale, > > `MessageFormat` when created with a `null` locale may throw a > `NullPointerException` either during the object creati

Re: RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException

2023-07-17 Thread Naoto Sato
On Mon, 17 Jul 2023 21:04:48 GMT, Justin Lu wrote: > Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197) > which updates the javadoc for the constructor of MessageFormat regarding a > `null` locale, > > `MessageFormat` when created with a `null` locale may throw a > `