Re: RFR: 6356745: (coll) Add PriorityQueue(Collection, Comparator) [v4]

2023-12-29 Thread jmehrens
On Mon, 25 Dec 2023 05:52:51 GMT, jmehrens wrote: >> Valeh Hajiyev has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated the javadoc > > Would adding a fast path to addAll solve this issue? I asked this back in > 2006 in JDK-6356745.

Re: RFR: 6356745: (coll) Add PriorityQueue(Collection, Comparator) [v4]

2023-12-27 Thread Valeh Hajiyev
On Mon, 25 Dec 2023 05:52:51 GMT, jmehrens wrote: >> Valeh Hajiyev has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated the javadoc > > Would adding a fast path to addAll solve this issue? I asked this back in > 2006 in JDK-6356745.

Re: RFR: 6356745: (coll) Add PriorityQueue(Collection, Comparator) [v4]

2023-12-27 Thread Valeh Hajiyev
On Wed, 20 Dec 2023 05:12:05 GMT, Stuart Marks wrote: >> Valeh Hajiyev has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated the javadoc > > src/java.base/share/classes/java/util/PriorityQueue.java line 216: > >> 214: * specified

Re: RFR: 6356745: (coll) Add PriorityQueue(Collection, Comparator) [v4]

2023-12-24 Thread jmehrens
On Tue, 19 Dec 2023 21:17:02 GMT, Valeh Hajiyev wrote: >> This commit addresses the current limitation in the `PriorityQueue` >> implementation, which lacks a constructor to efficiently create a priority >> queue with a custom comparator and an existing collection. In order to >> create such a

Re: RFR: 6356745: (coll) Add PriorityQueue(Collection, Comparator) [v4]

2023-12-19 Thread Stuart Marks
On Tue, 19 Dec 2023 21:17:02 GMT, Valeh Hajiyev wrote: >> This commit addresses the current limitation in the `PriorityQueue` >> implementation, which lacks a constructor to efficiently create a priority >> queue with a custom comparator and an existing collection. In order to >> create such a

Re: RFR: 6356745: (coll) Add PriorityQueue(Collection, Comparator) [v4]

2023-12-19 Thread Valeh Hajiyev
> This commit addresses the current limitation in the `PriorityQueue` > implementation, which lacks a constructor to efficiently create a priority > queue with a custom comparator and an existing collection. In order to create > such a queue, we currently need to initialize a new queue with cust