Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater [v3]

2025-01-25 Thread Archie Cobbs
On Fri, 24 Jan 2025 20:57:15 GMT, Eirik Bjørsnøs wrote: > A tangential concern when allowing a custom deflater / inflater is to > document the resposibility for resource management. I've added a Javadoc blurb to that effect in 3807de16b70. Something similar (once the verbiage is agreed upon) s

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater [v4]

2025-01-25 Thread Archie Cobbs
> The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater` argument supplied by the caller, `GZIPOutputStream` has

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater [v3]

2025-01-24 Thread Eirik Bjørsnøs
On Thu, 2 Jan 2025 18:26:16 GMT, Archie Cobbs wrote: >> The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is >> logical because the GZIP encoding is based on ZLIB "deflate" encoding. >> >> However, while `DeflaterOutputStream` provides constructors that take a >> custom `Defla

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2025-01-24 Thread Lance Andersen
On Fri, 19 Jul 2024 15:16:01 GMT, Lance Andersen wrote: >>> I understand the request here, but is there a current use case for needing >>> a custom Deflater? >> >> I think the primary use case is when you want to set a non-default >> compression level, e.g., "best" or "fast". This is a pretty

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2025-01-15 Thread Archie Cobbs
On Fri, 19 Jul 2024 15:16:01 GMT, Lance Andersen wrote: >>> I understand the request here, but is there a current use case for needing >>> a custom Deflater? >> >> I think the primary use case is when you want to set a non-default >> compression level, e.g., "best" or "fast". This is a pretty

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater [v3]

2025-01-02 Thread Archie Cobbs
> The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater` argument supplied by the caller, `GZIPOutputStream` has

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2024-11-25 Thread Archie Cobbs
On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote: > The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater`

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater [v2]

2024-11-25 Thread Archie Cobbs
> The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater` argument supplied by the caller, `GZIPOutputStream` has

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2024-11-25 Thread Chen Liang
On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote: > The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater`

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2024-07-19 Thread Lance Andersen
On Fri, 19 Jul 2024 14:07:07 GMT, Archie Cobbs wrote: > > I understand the request here, but is there a current use case for needing > > a custom Deflater? > > I think the primary use case is when you want to set a non-default > compression level, e.g., "best" or "fast". This is a pretty norma

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2024-07-19 Thread Archie Cobbs
On Fri, 19 Jul 2024 10:41:05 GMT, Lance Andersen wrote: > I understand the request here, but is there a current use case for needing a > custom Deflater? I think the primary use case is when you want to set a non-default compression level, e.g., "best" or "fast". This is a pretty normal thing

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2024-07-19 Thread Lance Andersen
On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote: > The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater`

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2024-07-18 Thread Jaikiran Pai
On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote: > The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater`

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

2024-07-18 Thread Chen Liang
On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote: > The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater`